From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 7a8f22b: * test/lisp/url/url-file-tests.el (url-file): Use file:///, not file://. Date: Fri, 28 Jun 2019 03:22:54 +0200 Message-ID: References: <20190615033014.12012.75126@vcs0.savannah.gnu.org> <20190615033015.46910210EC@vcs0.savannah.gnu.org> <9c367baa-841d-24e0-1436-1a8f3a3ed081@cornell.edu> <012f2cd6-10c7-4960-72e2-7a773bd5d4f8@cornell.edu> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000685f4b058c582037" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="72994"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "emacs-devel@gnu.org" To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 28 03:24:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgfd0-000IoS-JF for ged-emacs-devel@m.gmane.org; Fri, 28 Jun 2019 03:24:38 +0200 Original-Received: from localhost ([::1]:55536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgfcw-000712-Ic for ged-emacs-devel@m.gmane.org; Thu, 27 Jun 2019 21:24:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44422) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgfby-00070v-DS for emacs-devel@gnu.org; Thu, 27 Jun 2019 21:23:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgfbx-0004YA-Ff for emacs-devel@gnu.org; Thu, 27 Jun 2019 21:23:34 -0400 Original-Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]:36559) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgfbx-0004X7-9I for emacs-devel@gnu.org; Thu, 27 Jun 2019 21:23:33 -0400 Original-Received: by mail-qt1-x82d.google.com with SMTP id p15so4625458qtl.3 for ; Thu, 27 Jun 2019 18:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v5BxBURQrgwSxqhjHj0VUohkwO+mEcx9dxR52+btJbk=; b=ftQzuO9O4L+tt0FoMSwO1NRUoJCmHzZwJnedBfx3K1iEVEP4CjwL+fYYbIhQiT0bxL TFzvTriL83OuAJigQw9MGwBm5Q+fuhNm+ZkZvZ/nrajuBvPpzhYeBps653QMoQJsDAhr KdkYOzKtrGMjLmnLuAgWPlfXQ8t/X8npF4SOLErSWD733VUoo068ZcnYefrpXa7Uahly 3cKKO3Nxa03HCS/VmDFvJ1httWDCKNTNz+z+EUFOx26+5HhivE6RP5ggRGCaj1jVY1Zn hWUC4pN/lvoG7xHyc9rah7FSRo2bs5LEHVn28zsxhZL/IfntmMoVwU7PnoiJiJczVGwK 3cAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v5BxBURQrgwSxqhjHj0VUohkwO+mEcx9dxR52+btJbk=; b=Dqd7T7YH95HVwXCXDr2jXalU7J4Be5tZgNxRKXHS/keunWY/yRwHYUKP02MyM9fE67 yMBwWJYHo/4F0b8ep+YaqVHYf+PNH7hi2HaQuNtD3jVcWw8eQF2+Amki1LCYrGdMVvVL 5d1GHLOfyOipvCw0m1v5hg6+ck3eJh5J8bSiNgmJhRv7JwmOyqfaA9XI7S/Q1Bsje+cO okFtL0+oxLIhNiBBXR3vttJJr4uy0I0gza5PmIDJycHprLHASx23A21flAdpz+GzWUSm k/qXVTT48P9K13bfjgNre66Q7etTYawj2J1GQQroC1iQvxim1kE0l8BWONz4KpP60cEC u0Ew== X-Gm-Message-State: APjAAAUoiNs0WoGoFh0lEEzWm1L/wiKYGcHwrVJO8PvaapbC2WvNtJXx nkjNZ/OqpR6zAU6ph41Jb36zGZbtgEF4qCfqVHw= X-Google-Smtp-Source: APXvYqyNExnJCgKvHid1URdRLYQ+GwxYGf5lfDsFrUIw6R/kF9oI0v9e8HEjsJrJ0im8RK46O2mKUIjEpHRnt0XWBNQ= X-Received: by 2002:a0c:b5c5:: with SMTP id o5mr6136823qvf.6.1561685012273; Thu, 27 Jun 2019 18:23:32 -0700 (PDT) In-Reply-To: <012f2cd6-10c7-4960-72e2-7a773bd5d4f8@cornell.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238208 Archived-At: --000000000000685f4b058c582037 Content-Type: text/plain; charset="UTF-8" On Fri, Jun 28, 2019 at 1:37 AM Ken Brown wrote: > This is exactly what I said. From the context, I think it's clear that the > words "path", "to", and "file" don't contain slashes. If "path" does not contain slashes (with which I agree), concatenating it to file:/// (not file://) is the right thing to do. Anyway, if the check fails on Cygwin, the only fix is special-casing the test according to system-type. Feel free to do it. No idea whether ms-dos and darwin work with file:/// or file:// or both. --000000000000685f4b058c582037 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Fri, Jun 28, 2019 at 1:37 AM Ken Brown= <kbrown@cornell.edu> wrote= :

> This is exactly what I said.=C2=A0 From the = context, I think it's clear that the
> words "path", &q= uot;to", and "file" don't contain slashes.

If "path"= does not contain slashes (with which I agree), concatenating it to file://= / (not file://) is the right thing to do.
<= br>
Anyway, if the check fails on Cygwin, t= he only fix is special-casing the test according to system-type. Feel free = to do it. No idea whether ms-dos and darwin work with file:/// or file:// o= r both.

--000000000000685f4b058c582037--