From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: simplifying windmove-frame-edges Date: Fri, 25 Oct 2019 16:05:06 +0200 Message-ID: References: <6ac9e01d-83f2-cb1a-b09b-a5a8c8cc7b44@gmx.at> <83h83yxmgg.fsf@gnu.org> <83imodvvhl.fsf@gnu.org> <83ftjhvt43.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000043b6420595bca5a1" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="46746"; mail-complaints-to="usenet@blaine.gmane.org" Cc: martin rudalics , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 25 16:08:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iO0Ge-000C0L-Ho for ged-emacs-devel@m.gmane.org; Fri, 25 Oct 2019 16:08:40 +0200 Original-Received: from localhost ([::1]:60564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO0Gc-0007W2-U6 for ged-emacs-devel@m.gmane.org; Fri, 25 Oct 2019 10:08:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41385) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO0Ds-0001oX-7P for emacs-devel@gnu.org; Fri, 25 Oct 2019 10:05:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iO0Dq-0000PI-Qf for emacs-devel@gnu.org; Fri, 25 Oct 2019 10:05:47 -0400 Original-Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:46603) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iO0Dn-0000NG-LB; Fri, 25 Oct 2019 10:05:43 -0400 Original-Received: by mail-qt1-x82b.google.com with SMTP id u22so3327607qtq.13; Fri, 25 Oct 2019 07:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wm3bf1D8R6GoLcfP0vsDz0Lc6hX+DtJh2lZTdIQVhfM=; b=dGGbAUinRr3I4VEFLFNKg2eb3noXIAvsbtqqG/DQUJIYM+wGmwuKWGaRl1XInYkcpW 3kRDi9MJKe9rTSbZuvLCsivpEH08gvPfL2RkO8MmO1SsYyA7Vk6z9klPfoxtKbtCiszN +X8x/BTh6UrjQMCuy76Hz9ifxPFaLuCJxe1/LMYGuJ989NBqEr9u7qzgtCCIxvbtiSVN nH3tEFSOjFCc7qKNeEl9jM+wehfki0pqftnJZDLtAODeyQe73t6DAfva7w7fleei3+o8 uLN5Vny0k5GOCDCq2UR/KAE4PoQRU8uUlU5k+saA+454eBcIB2xRnFHeStzhqeNh7CbL 3BdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wm3bf1D8R6GoLcfP0vsDz0Lc6hX+DtJh2lZTdIQVhfM=; b=AZSoLeD8SpqC7M1pIXkjUO8JUnPE8APRGQk5xByGOOfBwFizFjwSP5qyAn+/MhbrNg VMZy2qFITxg0/XwyPEnNbmhJ57k4RwwJlX/DxymlXl92eYPkZjWOJ+4i6wehdi8xL0gi Csg/LZuUnBt3xMYbKxmXhgGSeIpVc7x6cpzfQ6YQyz2AnEh0mGQkAmvATjGHNmkAr1w/ 2TeKMBQsx+rLIV0AUhWeavdwx//Yc0mUju5j+6IkH0r9iNhkoWyzCgJo/J8Lrjn5xPke TOBAgubuxPcsbMgdcnTB175T1bLSAXNvNKxLigRpwk87KhajlUbTQchjasNwRc2e9WlU 3Wdg== X-Gm-Message-State: APjAAAVbHjlY51Av4IJBcPZxuvRxnAeTxCQp0dBx2rRXAxkNGpMikDu9 hs6bger0tVMvDtiNEuGnUAa1Kin6VxgPc1XWx8mKXA== X-Google-Smtp-Source: APXvYqxZznJBh8Z2+RQwFHTQ6Bs0n0NpyAWRMDtDsA8JkRMKUtIXH017Gv8WEgsufsBJUBuKfEHcXThmYsegLgmT9WY= X-Received: by 2002:aed:3063:: with SMTP id 90mr3213297qte.242.1572012342618; Fri, 25 Oct 2019 07:05:42 -0700 (PDT) In-Reply-To: <83ftjhvt43.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241416 Archived-At: --00000000000043b6420595bca5a1 Content-Type: text/plain; charset="UTF-8" On Fri, Oct 25, 2019 at 3:43 PM Eli Zaretskii wrote: > So you are saying that nothing in those comments is relevant for the > implementation of non-obsolete functions? IOW, no reasonable amount > of changes in the comments will ever yield anything useful for the > code we now consider the mainstream? If so, then yes, removing those > comments is TRT. Yes, I think so. The only relevant info in that big "implementation note" fragment is a duplicate of the comment at the beginning of the file. The rest are just details about how to find the window, or talk about window and frame coordinates. Neither of those is relevant with the `window-in-direction' implementation. --00000000000043b6420595bca5a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 25, 2019 at 3:43 PM Eli Zaretskii <eliz@gnu.org> wrote:
<= br>
> So you are saying that nothing in those comments is relevant f= or the
> implementation of non-obsolete functions?=C2=A0 IOW, no reas= onable amount
> of changes in the comments will ever yield anything u= seful for the
> code we now consider the mainstream?=C2=A0 If so, the= n yes, removing those
> comments is TRT.

Yes, I think so. The = only relevant info in that big "implementation note" fragment is = a duplicate of the comment at the beginning of the file. The rest are just = details about how to find the window, or talk about window and frame coordi= nates. Neither of those is relevant with the `window-in-direction' impl= ementation.

--00000000000043b6420595bca5a1--