From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Fixing some warnings in emacs-26 Date: Sat, 8 Jun 2019 09:07:43 +0200 Message-ID: References: <838sucpoiq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182298"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 08 09:08:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZVT9-000lKb-9l for ged-emacs-devel@m.gmane.org; Sat, 08 Jun 2019 09:08:51 +0200 Original-Received: from localhost ([::1]:55910 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZVT7-0000li-Lt for ged-emacs-devel@m.gmane.org; Sat, 08 Jun 2019 03:08:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48154) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZVSu-0000br-Sq for emacs-devel@gnu.org; Sat, 08 Jun 2019 03:08:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZVSs-0003Tn-HG for emacs-devel@gnu.org; Sat, 08 Jun 2019 03:08:35 -0400 Original-Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]:36383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZVSn-0003JR-5s; Sat, 08 Jun 2019 03:08:29 -0400 Original-Received: by mail-qt1-x835.google.com with SMTP id u12so4970127qth.3; Sat, 08 Jun 2019 00:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DJNU+pK4QDvSeE9Ioo+xFpdcTxvxnCcSvEgpbrtm2/I=; b=rYESNg7X2oGDDNkaeuvL2vtSgb6F+1CvVa5Wb/y3rwY+ruj7vllNGjeVF8i0sAxsKP UABdgDw8DWv3YgOq3dSFKSkoOVpgkA+aMk/tCTsntb3qcnWAOkn9OSYc+H8hXmpf+/On rPw+qnv9OCc2KQLL2uD3E+dZicF6AsGpTHdnqXC3hE1HquqOHPpTYve4fZF3SpfivC85 ZcX8HCxWjPP8F0HPbW8hJUX7ht7RRfJ+2jM1WnwDMIHjt9OZ2SOPDD50g81QnshW37TZ yAxl57GOzpti2D4AdrrILy4UlhJWr3YtDqnpX9NqukDSgI1LZbfehjV5uzEsJkEH85qW qpBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DJNU+pK4QDvSeE9Ioo+xFpdcTxvxnCcSvEgpbrtm2/I=; b=MGbD+za5E0DI+YRVMEE1xQqpxM95L241bh12w82auhO/hH5buOZpp64oKX+DJzCjwq 5+3JXpwU0HajDEIxduyd4IQ5Bu0D1eDe3zNbahkU4FVyKSZ7XSV8bpcXgcQjcvftk6N7 9Tu26MqKgwJpGd3esfzPpvKsI6MiaQwczgkK5+CBXhDnHXmJBWZMtvZjuEV0ttsCLu77 OifOm+m1JR2aHl8la41ls/4apTNfB3TTcJkJM5sw+QYSNpDVobcZ9P4jgIe3bCesQ2XX tLS3HVClmBxMzdl92CKvA95jf2wtrma7fvDinbphNBzsdzTMS44w3V9QLkWFmXu7xzxD C/+Q== X-Gm-Message-State: APjAAAXOZlZQjb6rPp7cwFZ/IhsIzdiR0km2mGg86xfOxolVvflUNSBE ASP1eesHTZdl9dHTM1Ssmy1ABfbCpMXbAl5Dtch1H2LvA1U= X-Google-Smtp-Source: APXvYqzaz7nWbQ1ZQNz06RwpxCzaGg6QRIB40SRtPM/1CZ0e+0pSHX2JgirXKmw9sx20al+kQOUCTspc3yYq8HScSt8= X-Received: by 2002:ac8:6105:: with SMTP id a5mr48909118qtm.242.1559977699926; Sat, 08 Jun 2019 00:08:19 -0700 (PDT) In-Reply-To: <838sucpoiq.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::835 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237325 Archived-At: > LGTM, thanks. However, please install those on master, as I'd like to > minimize changes on the release branch: we will start the pretest of > Emacs 26.3 soon. OK > Instead of the arbitrary value of 20, I'd prefer using sizeof for the > actual text (which should probably be assigned to a variable, to avoid > mentioning the same text twice). Done. Though I wanted to avoid adding complexity for a string message that's unlikely to change. Also, addpm.c already contains a few instances of hardcoded constants: /* Ensure there is enough room for "...\GNU Emacs\Emacs.lnk". */ if (strlen (start_folder) < (MAX_PATH - 20)) and char add_item[MAX_PATH*2 + 100]; etc.