From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#21816: elisp-mode-tests fails on a case-preserving filesystem Date: Mon, 2 Nov 2015 19:20:31 +0100 Message-ID: References: <83vb9kwahe.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1141d86e838f3a052392d7c6 X-Trace: ger.gmane.org 1446488538 17046 80.91.229.3 (2 Nov 2015 18:22:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Nov 2015 18:22:18 +0000 (UTC) Cc: 21816@debbugs.gnu.org, Stephen Leake To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 02 19:22:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZtJkA-0003MG-0j for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2015 19:22:10 +0100 Original-Received: from localhost ([::1]:43749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtJk9-0001FM-FG for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2015 13:22:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtJk6-0001FH-FN for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 13:22:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtJk2-0002yP-33 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 13:22:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtJk1-0002yJ-Vz for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 13:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZtJk1-00040J-MT for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 13:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2015 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21816-submit@debbugs.gnu.org id=B21816.144648847515319 (code B ref 21816); Mon, 02 Nov 2015 18:22:01 +0000 Original-Received: (at 21816) by debbugs.gnu.org; 2 Nov 2015 18:21:15 +0000 Original-Received: from localhost ([127.0.0.1]:49949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtJjG-0003z0-8Q for submit@debbugs.gnu.org; Mon, 02 Nov 2015 13:21:14 -0500 Original-Received: from mail-lf0-f49.google.com ([209.85.215.49]:36485) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtJjE-0003ys-HC for 21816@debbugs.gnu.org; Mon, 02 Nov 2015 13:21:13 -0500 Original-Received: by lffz202 with SMTP id z202so65723634lff.3 for <21816@debbugs.gnu.org>; Mon, 02 Nov 2015 10:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=ZGOdoxinoZV+gAAfW0zy2reTtTKM/E9onItDp9SAbis=; b=zAo75UnExdlj6/JYnv27w2FakyKkFbdpi92i4TDaOIhgBRgqfGnLLx+Mm1huJuOabi 6ciW8URuiIrKwpeCJ1EhKjab9G4PfGN08CxWVPC+pcqYQD6RcPHv/hHqp9S+TWGcbe0u 7UVxm5w87MMA2mVpD1to8iYbvXBrJM76w0N6aPG8QeZ1CYyCOHslDIyBGLp9G7Ndakiv GiHogYOdjvK0Yk4ccv+d4JhITxv4borosHtpLs+hIECvoARugMZZQDJFW6jsaO26Ievq gQ7sOct7LoylHcOZ/eqAcQTjqPfYPAi6vfoMkf692iwfna/YpCKlwHN1UPkBhHhpYCZe 2SzA== X-Received: by 10.25.80.80 with SMTP id e77mr7023960lfb.11.1446488471471; Mon, 02 Nov 2015 10:21:11 -0800 (PST) Original-Received: by 10.25.217.132 with HTTP; Mon, 2 Nov 2015 10:20:31 -0800 (PST) In-Reply-To: <83vb9kwahe.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108313 Archived-At: --001a1141d86e838f3a052392d7c6 Content-Type: text/plain; charset=UTF-8 On Mon, Nov 2, 2015 at 6:57 PM, Eli Zaretskii wrote: > The comparison should use file-equal-p. Yes, that's one of the ugly ways to fix it that I mentioned. "Ugly" because the test, through a macro, is not comparing file names, but two structures, which happen to have a field that contains a filename. IOW, we'll have to go from (should (equal xref (or (when (consp expected) (car expected)) expected))) to defining a new comparing function, specific to this test. Which I suppose I'll eventually do. --001a1141d86e838f3a052392d7c6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Mon, Nov 2, 2015 at 6:57 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> The c= omparison should use file-equal-p.

Yes, that's= one of the ugly ways to fix it that I mentioned. "Ugly" because = the test, through a macro, is not comparing file names, but two structures,= which happen to have a field that contains a filename. IOW, we'll have= to go from

=C2=A0 =C2=A0 =C2=A0(should (equa= l xref
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(or (when (consp expected) (car expected)) expected)))<= /div>

to defining a new comparing function, specif= ic to this test. Which I suppose I'll eventually do.

--001a1141d86e838f3a052392d7c6--