all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: 16793@debbugs.gnu.org
Subject: bug#16793: window-state-put needs a live window
Date: Tue, 18 Feb 2014 22:18:22 +0100	[thread overview]
Message-ID: <CAAeL0SRVfecuebAYtNM+XDtE=vd1_nM299RJfc2C0SzGU6+w_A@mail.gmail.com> (raw)
In-Reply-To: <5303AEBC.6020509@gmx.at>

On Tue, Feb 18, 2014 at 8:04 PM, martin rudalics <rudalics@gmx.at> wrote:

> I tend to agree with you.  But the obvious consequence is that the
> WINDOW argument of `window-state-put' could then specify an internal
> window that is not the root window of its frame.  In this case plain
> `delete-other-windows' would be the wrong action.

Yeah. In my workaround that wasn't important because I specifically
got the frame's root.

>  I attach a patch.

Was this:

> +       (setq window (catch 'live
> +                      (walk-window-subtree
> +                       (lambda (window)
> +                         (when (window-live-p window)))
> +                       root))))

intended to be

  (setq window (catch 'live
                 (walk-window-subtree
                  (lambda (window)
                    (when (window-live-p window)
                      (throw 'live window)))
                  root))))

I suppose?

   J





  reply	other threads:[~2014-02-18 21:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 16:20 bug#16793: window-state-put needs a live window Juanma Barranquero
2014-02-18 17:09 ` Stefan Monnier
2014-02-18 17:20   ` Glenn Morris
2014-02-18 17:24     ` Glenn Morris
2014-02-18 18:28       ` Stefan Monnier
2014-02-18 18:37         ` Glenn Morris
2014-02-18 20:45           ` Stefan Monnier
2014-02-18 17:36   ` Juanma Barranquero
2014-02-18 18:29     ` Stefan Monnier
2014-02-18 19:04     ` martin rudalics
2014-02-18 21:18       ` Juanma Barranquero [this message]
2014-02-18 21:26         ` martin rudalics
2014-02-18 21:51           ` Juanma Barranquero
2014-02-19 10:02             ` martin rudalics
2014-02-19 11:09               ` Juanma Barranquero
2014-02-18 19:04 ` martin rudalics
2014-02-18 19:08   ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeL0SRVfecuebAYtNM+XDtE=vd1_nM299RJfc2C0SzGU6+w_A@mail.gmail.com' \
    --to=lekktu@gmail.com \
    --cc=16793@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.