On Fri, Nov 6, 2015 at 3:16 AM, John Wiegley <jwiegley@gmail.com> wrote:

> Advice is only to be used by user code, not in core. It's the "last line"
of
> customization, but shouldn't be a programming style for developers.

We have still some work to do.

C:\...\trunk> git grep "(advice-add" lisp/*.el | grep -v advice.el
lisp/emacs-lisp/cl-macs.el:(advice-add 'pcase--mutually-exclusive-p
lisp/emacs-lisp/cl.el:(advice-add 'dolist :around #'cl--wrap-in-nil-block)
lisp/emacs-lisp/cl.el:(advice-add 'dotimes :around #'cl--wrap-in-nil-block)
lisp/emacs-lisp/cl.el:(advice-add 'declare :after
#'cl--pass-args-to-cl-declare)
lisp/emacs-lisp/debug.el:  (advice-add function :before
#'debug--implement-debug-on-entry
lisp/emacs-lisp/edebug.el:  (advice-add 'eval-defun :override
#'edebug-eval-defun))
lisp/emacs-lisp/edebug.el:'(advice-add 'debug-on-entry :around
'edebug--debug-on-entry)  ;; Should we do this?
lisp/emacs-lisp/eieio.el:(advice-add 'edebug-prin1-to-string
lisp/emacs-lisp/elp.el:    (advice-add funsym :around (elp--make-wrapper
funsym)
lisp/emacs-lisp/trace.el:  (advice-add
lisp/eshell/em-ls.el:             (advice-add 'insert-directory :around
lisp/ls-lisp.el:(advice-add 'insert-directory :around
#'ls-lisp--insert-directory)
lisp/progmodes/elisp-mode.el:                    (advice-add 'macroexpand
:around macroexpand-advice)
lisp/ses.el:(advice-add 'copy-region-as-kill :around
#'ses--advice-copy-region-as-kill)
lisp/ses.el:(advice-add 'yank :around #'ses--advice-yank)
lisp/uniquify.el:(advice-add 'rename-buffer :around
#'uniquify--rename-buffer-advice)
lisp/uniquify.el:(advice-add 'create-file-buffer :around
#'uniquify--create-file-buffer-advice)