all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* tramp-test42-auto-load failure
@ 2019-06-15  5:43 Juanma Barranquero
  2019-06-15 10:28 ` Michael Albinus
  0 siblings, 1 reply; 4+ messages in thread
From: Juanma Barranquero @ 2019-06-15  5:43 UTC (permalink / raw)
  To: Emacs developers

tramp-test42-auto-load fails on Windows because remote directories are
not being tested, for lack of a suitable default. So
'tramp-test-temporary-file-directory' is set to "NUL", and
(file-remote-p "NUL") = nil.

In fact, the test used to have

   (skip-unless (tramp--test-enabled))

until commit ad99550610542f8333dc964b3bef2b9e6ad7b0f6, where it was removed.

I've sort of "fixed" it by making the test expect a failure when
'tramp--test-enabled' returns nil, because I didn't want to second
guess that commit's author, Michael Albinus.

Yet I think reverting at least part of that change would be a better
fix, because now it is "expected to fail" on Windows, while the truth
is that the test is not failing; it should simply be skipped.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-15 19:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-15  5:43 tramp-test42-auto-load failure Juanma Barranquero
2019-06-15 10:28 ` Michael Albinus
2019-06-15 19:40   ` Michael Albinus
2019-06-15 19:54     ` Juanma Barranquero

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.