From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#38248: help-follow-symbol silent when no symbol was found Date: Sun, 17 Nov 2019 20:40:33 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000003cbae3059790030f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="44870"; mail-complaints-to="usenet@blaine.gmane.org" To: 38248@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 17 20:42:26 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWQRF-000BY2-T1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 20:42:26 +0100 Original-Received: from localhost ([::1]:56002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWQRE-0005c1-Ii for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 14:42:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55262) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWQQt-0005bv-6d for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 14:42:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWQQs-0007gd-5a for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 14:42:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWQQs-0007gQ-2H for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 14:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWQQr-0006F6-Py for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 14:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2019 19:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38248 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Bug-Gnu-Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.157401967523943 (code B ref -1); Sun, 17 Nov 2019 19:42:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Nov 2019 19:41:15 +0000 Original-Received: from localhost ([127.0.0.1]:42691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWQQ6-0006E6-LC for submit@debbugs.gnu.org; Sun, 17 Nov 2019 14:41:14 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:50896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWQQ5-0006Dz-58 for submit@debbugs.gnu.org; Sun, 17 Nov 2019 14:41:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55204) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWQQ4-0005bV-0e for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 14:41:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWQQ2-0007EL-SL for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 14:41:11 -0500 Original-Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:34083) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWQQ2-0007DZ-NW for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 14:41:10 -0500 Original-Received: by mail-qk1-x730.google.com with SMTP id 205so12615305qkk.1 for ; Sun, 17 Nov 2019 11:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=AbnUARA4oyjFb3VNe7nCkzlLw3p2aB/PWwA/yb9lvfM=; b=YyI1caqglY11HPxLGJskieaOFMTOIrabC8TgRYNMdrvQlWoC5QpmGrcojGpwR6SlwH yLGQSfDRz4JgLLhUoqe4k6nD84ehB+RAP3Dl1kE61GEhDK8rPzAmWVvPVK6P7Z6PAbZV 55j+b/6BFHEpeDkIWj8lMnrbWhxaYt9E9cnwaz0SRwcxZ9SGgddIqQao6bjskz+jDHXw Pd11DTyHXEqfJAT4iTAT81bfJIlDCzFVqi90hllNiSXANlhtAB4j3GPAD9H4bMkfbz2k E2ZNH9xXXYs1f0uBNG8XWZ02x/IiTZ4y3IxmgUsEv1Ka0nD34uLBnkhyya76zWwDcPGV oonQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=AbnUARA4oyjFb3VNe7nCkzlLw3p2aB/PWwA/yb9lvfM=; b=qqtvWmevkGoNB3MaZ5zcxBgG0jPjMPmudQQ8q2/iwT32ezNUN7nqenQC9f3ezzbUZ7 ZOzE3ADzMwnBk9Li/FNsX4Ym3OMqe8sn+4bOJB4DmsqrkYdBbibB/tOZVWkGJk0KhhoN iZvB0iXgqQvtX3J0AuTz1ibKBEamH3uxJ1jTWzBb/oGINMfX1c+szJzQWfWz1OSwZKMt TOvm4k7A+jYhiy8+iYZ2ekOPcL34mWHI6zUEQyzPlpR1gR2fHmlu3t0kMRqEQdwsV3Yf 7HPfhUafHAjpwEjwhw2wuGEOvc/VVIJMfNQN9RRZkBLXRckjiUvIrUKfLB/Bi0QAZKs7 0vPA== X-Gm-Message-State: APjAAAUmZ+Nk/3jA4VnXW46V9klHSf1lEHZhKt7jXAQ12VnsXO0TMwgg bSMe2owZVh7r/r0zpIZe0KuPr4u/qR+zMnGoHkD9/w== X-Google-Smtp-Source: APXvYqy+JWVbCzdeMOXtFcumgJx6z4dwQyduXSa4sg3c9UzAYPPGl6X5DS0tDvicY8oLR0cpeK1HgKFRHrkzcHlzbBk= X-Received: by 2002:a37:4f8a:: with SMTP id d132mr21994834qkb.185.1574019668941; Sun, 17 Nov 2019 11:41:08 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171852 Archived-At: --0000000000003cbae3059790030f Content-Type: multipart/alternative; boundary="0000000000003cbadd059790030d" --0000000000003cbadd059790030d Content-Type: text/plain; charset="UTF-8" Package: emacs Severity: minor Tags: patch Currently, help-follow and help-follow-mouse signal an error if there's nothing to follow. However, help-follow-symbol does not, which means that C-c C-c in the help buffer when over an arbitrary non-symbol does nothing and says nothing. That's not just inconsistent, but a bit disconcerting, as sometimes following a symbol can be slow. In my build, it takes a second or more to show the symbol documentation, so when there's no symbol I stand waiting for something to happen for a couple of seconds. The following patch fixes that. The only reason against I can think of is when `help-follow-symbol' is called from elisp, because it will now signal an error. However, at least in the Emacs sources help-follow-symbol is never called from elisp, just as a keybinding or menu entry. --0000000000003cbadd059790030d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Package: emacs
Severity: minor
Tags: patch

Currently, help-follow and help-follow-mouse signal= an error if there's nothing to follow. However, help-follow-symbol doe= s not, which means that C-c C-c in the help buffer when over an arbitrary n= on-symbol does nothing and says nothing.

That'= s not just inconsistent, but a bit disconcerting, as sometimes following a = symbol can be slow. In my build, it takes a second or more to show the symb= ol documentation, so when there's no symbol I stand waiting for somethi= ng to happen for a couple of seconds.

The followin= g patch fixes that. The only=C2=A0reason against I can think of is when `he= lp-follow-symbol' is called from elisp, because it will now signal an e= rror. However, at least in the Emacs sources help-follow-symbol is never ca= lled from elisp, just as a keybinding or menu entry.

--0000000000003cbadd059790030d-- --0000000000003cbae3059790030f Content-Type: application/octet-stream; name="0001-lisp-help-mode.el-help-follow-symbol-Signal-no-symbo.patch" Content-Disposition: attachment; filename="0001-lisp-help-mode.el-help-follow-symbol-Signal-no-symbo.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k33ell130 RnJvbSA0ZmI4ZThjMTI0MDA5YWIyODNmYjlkMTVhZDdhYWEwYTkwZjU2ZWM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdWFubWEgQmFycmFucXVlcm8gPGxla2t0dUBnbWFpbC5jb20+ CkRhdGU6IFN1biwgMTcgTm92IDIwMTkgMjA6Mjc6MTIgKzAxMDAKU3ViamVjdDogW1BBVENIXSAq IGxpc3AvaGVscC1tb2RlLmVsIChoZWxwLWZvbGxvdy1zeW1ib2wpOiBTaWduYWwgbm8gc3ltYm9s IGF0CiBwb2ludC4KCi0tLQogbGlzcC9oZWxwLW1vZGUuZWwgfCA5ICsrKysrLS0tLQogMSBmaWxl IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9s aXNwL2hlbHAtbW9kZS5lbCBiL2xpc3AvaGVscC1tb2RlLmVsCmluZGV4IDA1NGExZWY4YzIuLmU3 MDU3MGMzZWUgMTAwNjQ0Ci0tLSBhL2xpc3AvaGVscC1tb2RlLmVsCisrKyBiL2xpc3AvaGVscC1t b2RlLmVsCkBAIC03NDksMTAgKzc0OSwxMSBAQCBoZWxwLWZvbGxvdy1zeW1ib2wKIAkgICAgKGJ1 ZmZlci1zdWJzdHJpbmcgKHBvaW50KQogCQkJICAgICAgKHByb2duIChza2lwLXN5bnRheC1mb3J3 YXJkICJ3XyIpCiAJCQkJICAgICAocG9pbnQpKSkpKSkpCi0gICAgKHdoZW4gKG9yIChib3VuZHAg c3ltKQotCSAgICAgIChnZXQgc3ltICd2YXJpYWJsZS1kb2N1bWVudGF0aW9uKQotCSAgICAgIChm Ym91bmRwIHN5bSkgKGZhY2VwIHN5bSkpCi0gICAgICAoaGVscC1kby14cmVmIHBvcyAjJ2Rlc2Ny aWJlLXN5bWJvbCAobGlzdCBzeW0pKSkpKQorICAgIChpZiAob3IgKGJvdW5kcCBzeW0pCisJICAg IChnZXQgc3ltICd2YXJpYWJsZS1kb2N1bWVudGF0aW9uKQorCSAgICAoZmJvdW5kcCBzeW0pIChm YWNlcCBzeW0pKQorICAgICAgICAoaGVscC1kby14cmVmIHBvcyAjJ2Rlc2NyaWJlLXN5bWJvbCAo bGlzdCBzeW0pKQorICAgICAgKHVzZXItZXJyb3IgIk5vIHN5bWJvbCBoZXJlIikpKSkKIAogKGRl ZnVuIGhlbHAtbW9kZS1yZXZlcnQtYnVmZmVyIChfaWdub3JlLWF1dG8gbm9jb25maXJtKQogICAo d2hlbiAob3Igbm9jb25maXJtICh5ZXMtb3Itbm8tcCAiUmV2ZXJ0IGhlbHAgYnVmZmVyPyAiKSkK LS0gCjIuMjMuMC53aW5kb3dzLjEKCg== --0000000000003cbae3059790030f--