From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names. Date: Thu, 9 Jan 2014 15:45:42 +0100 Message-ID: References: <20140109052705.GA3424@thyrsus.com> <20140109123702.GB5361@thyrsus.com> <20140109131337.GA6053@thyrsus.com> <20140109134716.GA6290@thyrsus.com> <20140109142956.GA6731@thyrsus.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1389278793 18407 80.91.229.3 (9 Jan 2014 14:46:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jan 2014 14:46:33 +0000 (UTC) Cc: Bastien , Emacs developers To: Eric Raymond Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 09 15:46:40 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W1GsZ-0001RX-Ek for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 15:46:39 +0100 Original-Received: from localhost ([::1]:52378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1GsZ-0002mq-4h for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 09:46:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1GsU-0002mk-KT for emacs-devel@gnu.org; Thu, 09 Jan 2014 09:46:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1GsL-0003bG-Lc for emacs-devel@gnu.org; Thu, 09 Jan 2014 09:46:34 -0500 Original-Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:41469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1GsJ-0003Wk-JV; Thu, 09 Jan 2014 09:46:23 -0500 Original-Received: by mail-ee0-f52.google.com with SMTP id d17so1374469eek.11 for ; Thu, 09 Jan 2014 06:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=dA3hJxKduQH/lUvzewvNhv2hwB6ZBspvLUwzedOesqs=; b=kI0F+nIQuzeNqJKoirUveJOH83HHv/Kezm7rgtgu9uRyn48X4XtdLGaO+7HRfLv2ON 157GxxvLIYGL9tCInp4KBIivCqJ4o7mAIEC2GqErx/unKyqPkdHV1lKLXraPQ5eJ4HQh YsGCcLgwJPiOYEXbmfzp23lqvFEuL1xIHWSKzthdI1tGCyqBFq41KG/IJVwtMfcGX80t YwPGTJpr17I6Uy/PUDHQO39VqXEleChKm3/gZtTPW84Pl9nJRzVnPswCNXutJ30tbW3q Aqkslvq6Bzat9kXv1Fq7375IDI9hOWVSprFde3L0tLihWW2CPPWaSwy+Q10FmVpPWngf u45g== X-Received: by 10.15.53.200 with SMTP id r48mr3412399eew.111.1389278782341; Thu, 09 Jan 2014 06:46:22 -0800 (PST) Original-Received: by 10.14.209.69 with HTTP; Thu, 9 Jan 2014 06:45:42 -0800 (PST) In-Reply-To: <20140109142956.GA6731@thyrsus.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167913 Archived-At: On Thu, Jan 9, 2014 at 3:29 PM, Eric S. Raymond wrote: > By your own analysis, there is *no* compatible fix. Whatever the function > and variable are called, stuff is going to break because the revision-ID > format is different. It won't be able to extract the required information, because it will not exist anymore. But, as that code is checking for nil, it won't break. Your change will make it break: (setq emacs-repository-version "fce2a09142ddccc242931edd16712c2c24e10e8e") Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p fce2a09142ddccc242931edd16712c2c24e10e8e) -(115933 fce2a09142ddccc242931edd16712c2c24e10e8e) (and (and (boundp (quote emacs-bzr-version)) emacs-bzr-version) (- (read (emacs-bzr-get-version)) (read emacs-bzr-version))) eval((and (and (boundp (quote emacs-bzr-version)) emacs-bzr-version) (- (read (emacs-bzr-get-version)) (read emacs-bzr-version))) nil) eval-last-sexp-1(nil) eval-last-sexp(nil) call-interactively(eval-last-sexp nil nil) command-execute(eval-last-sexp) > work any differently than with both aliases in place. Switching to Git with remove some functionality (specifically, being easily able to check how many commits there are between the compiled Emacs and the repository head). That cannot be helped, sort of looking for alternatives. I'm not complaining about lack of functionality, but code breaking. But anyway, that's not even the issue. The issue is that we had an interface which said that it would return a string with some format, or nil. You want to keep that interface, but make it return something different. That's incompatible *and* unnecessary. And you seem to insist just because you don't like the idea of the old APIs being around in loadup.el? J