From: Juanma Barranquero <lekktu@gmail.com>
To: 14795@debbugs.gnu.org
Subject: bug#14795: height parameter inconsistent in new vs existing frames when tool-bar is enabled
Date: Fri, 5 Jul 2013 01:11:35 +0200 [thread overview]
Message-ID: <CAAeL0SR+VFyV7hY3fX=_ZteY6-jHmfkL8dpFu28GCfYC6u8UJw@mail.gmail.com> (raw)
In-Reply-To: <CAAeL0SS3OAnWpxb+FvBzaX3g=2Pe0KetD-xBndyUK7ASt08F=w@mail.gmail.com>
Martin pointed out in emacs-devel that frame.c:x_figure_window_size()
includes the following comment:
/* Add the tool-bar height to the initial frame height so that the
user gets a text display area of the size he specified with -g or
via .Xdefaults. Later changes of the tool-bar height don't
change the frame size. This is done so that users can create
tall Emacs frames without having to guess how tall the tool-bar
will get. */
if (toolbar_p && FRAME_TOOL_BAR_LINES (f))
I remain unconvinced. That's mixing apples and oranges. If UI commands
(like -g) and UI settings (like X resources) should interpret the
frame height as meaning the client area, so be it. But then we should
decouple these from the `height' frame parameter, because it doesn't
really make sense to say that `height' means client area height when
creating a frame, but total frame height when modifying it.
next prev parent reply other threads:[~2013-07-04 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 22:52 bug#14795: height parameter inconsistent in new vs existing frames when tool-bar is enabled Juanma Barranquero
2013-07-04 23:11 ` Juanma Barranquero [this message]
2013-07-05 7:45 ` martin rudalics
2013-07-05 9:51 ` Juanma Barranquero
2013-07-05 9:29 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeL0SR+VFyV7hY3fX=_ZteY6-jHmfkL8dpFu28GCfYC6u8UJw@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=14795@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.