Please try building with librsvg on MS-Windows

Please try building with librsvg on MS-Windows

[Eli Zaretskii]

People who build Emacs on MS-Windows are encouraged to install the
ported librsvg 2.40 from the ezwinports site
(http://sourceforge.net/projects/ezwinports/files/), and build Emacs
with SVG image support.  My somewhat limited testing indicates that
the current version of librsvg and its prerequisites is stable enough
to allow us no longer regard the SVG support on Windows as
"experimental".

I updated the installation instructions in nt/INSTALL and
nt/README.W32, so look there for more info about librsvg.

Re: Please try building with librsvg on MS-Windows

[Dani Moncayo]

On Mon, Dec 23, 2013 at 7:38 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> People who build Emacs on MS-Windows are encouraged to install the
> ported librsvg 2.40 from the ezwinports site
> (http://sourceforge.net/projects/ezwinports/files/), and build Emacs
> with SVG image support.

Seems to work here.  I've uploaded the binary to
"https://sourceforge.net/projects/emacs-bin/files/snapshots/".

Thanks.

-- 
Dani Moncayo

Re: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> Date: Mon, 23 Dec 2013 21:18:18 +0100
> From: Dani Moncayo <dmoncayo@gmail.com>
> Cc: Emacs development discussions <emacs-devel@gnu.org>
> 
> On Mon, Dec 23, 2013 at 7:38 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > People who build Emacs on MS-Windows are encouraged to install the
> > ported librsvg 2.40 from the ezwinports site
> > (http://sourceforge.net/projects/ezwinports/files/), and build Emacs
> > with SVG image support.
> 
> Seems to work here.  I've uploaded the binary to
> "https://sourceforge.net/projects/emacs-bin/files/snapshots/".

Thanks for testing.

Re: Please try building with librsvg on MS-Windows

[Juanma Barranquero]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

On Mon, Dec 23, 2013 at 7:38 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> People who build Emacs on MS-Windows are encouraged to install the
> ported librsvg 2.40 from the ezwinports site
> (http://sourceforge.net/projects/ezwinports/files/), and build Emacs
> with SVG image support.  My somewhat limited testing indicates that
> the current version of librsvg and its prerequisites is stable enough
> to allow us no longer regard the SVG support on Windows as
> "experimental".

It builds OK and I see the splash just fine.

However, I tried with test SVGs from W3C and they are not displayed
correctly. I don't know if that's expected. As an example, see the
attached "good" image (as displayed by IE) and the "bad" one (from
Emacs) from the same SVG file.

[-- Attachment #2: bad.png --]
[-- Type: image/png, Size: 2331 bytes --]

[-- Attachment #3: good.png --]
[-- Type: image/png, Size: 11621 bytes --]

Re: Please try building with librsvg on MS-Windows

[Stephen J. Turnbull]

Juanma Barranquero writes:

 > However, I tried with test SVGs from W3C and they are not displayed
 > correctly. I don't know if that's expected.

No, it isn't.  SVGs that simple should just work.  Something is wrong
there.

Re: Please try building with librsvg on MS-Windows

[Juanma Barranquero]

On Tue, Dec 24, 2013 at 3:34 AM, Stephen J. Turnbull <stephen@xemacs.org> wrote:

> No, it isn't.  SVGs that simple should just work.  Something is wrong
> there.

They are test images, with references to other documents:

  <defs>
    <font-face font-family="SVGFreeSansASCII" unicode-range="U+0-7F">
      <font-face-src>
        <font-face-uri xlink:href="../resources/SVGFreeSans.svg#ascii"/>
      </font-face-src>
    </font-face>
  </defs>
  <g id="test-body-content" font-family="SVGFreeSansASCII,sans-serif"
font-size="18">
    <defs>
      <color-profile id="changeColor" name="changeColor"
xlink:href="../images/changeColor.ICM"/>
    </defs>
    <g>
      <image id="image1PNG" x="30" y="0" width="190" height="190"
xlink:href="../images/colorprof.png"/>
    </g>
    <g>
      <image color-profile="changeColor" id="image2" x="260" y="90"
width="190" height="190" xlink:href="../images/colorprof.png"/>
    </g>
    <text font-family="Arial" font-size="12" x="250" y="20">
      Basic test of ICC profile with an image.
    </text>
  </g>

so I suppose there's a number of things that could go wrong.

   J

Re: Please try building with librsvg on MS-Windows

[Stephen J. Turnbull]

Juanma Barranquero writes:
 > On Tue, Dec 24, 2013 at 3:34 AM, Stephen J. Turnbull <stephen@xemacs.org> wrote:
 > 
 > > No, it isn't.  SVGs that simple should just work.  Something is wrong
 > > there.
 > 
 > They are test images, with references to other documents:

Do you have those resources locally, and in the right places?  That
would definitely explain what you're seeing if you don't, because the
base URL would be your local file, and all of the hrefs will be
computed relative to that.

Try viewing them at W3C with a browser that has "Save as Web Page
(Complete)" capability, save it that way, and point Emacs at that,
perhaps after setting `default-directory' appropriately.

HTH

Steve

Re: Please try building with librsvg on MS-Windows

[Juanma Barranquero]

On Tue, Dec 24, 2013 at 4:40 AM, Stephen J. Turnbull <stephen@xemacs.org> wrote:

> Do you have those resources locally, and in the right places?

Yes, I unzipped the test suite ("SVG 1.1 Second Edition test suite"
from http://www.w3.org/Graphics/SVG/WG/wiki/Test_Suite_Overview) and
it creates the whole test tree. Also, IE and Chrome do show the images
correctly, so the required files are obviously there.

> Try viewing them at W3C with a browser that has "Save as Web Page
> (Complete)" capability

Such as?

   J

Re: Please try building with librsvg on MS-Windows

[Stephen J. Turnbull]

Juanma Barranquero writes:

 > Yes, I unzipped the test suite ("SVG 1.1 Second Edition test suite"
 > from http://www.w3.org/Graphics/SVG/WG/wiki/Test_Suite_Overview) and
 > it creates the whole test tree. Also, IE and Chrome do show the images
 > correctly, so the required files are obviously there.

Hm.  What is Emacs's default-directory when you invoke the view
command?  Maybe that's the problem.

 > > Try viewing them at W3C with a browser that has "Save as Web Page
 > > (Complete)" capability
 > 
 > Such as?

Not relevant if you downloaded the test suite, you already have the
files.  However, FYI both Google Chrome and Mozilla Firefox can do it.

bug#16240: Please try building with librsvg on MS-Windows

[Juanma Barranquero]

Package: emacs
Version: 24.3.50


Running from the root of the test suit:

  C:\...\svg> dir

   Directory of  C:\Devel\emacs\varios\images\svg\*

  24/12/2013  02:29         <DIR>    harness
  24/12/2013  02:29         <DIR>    images
  24/12/2013  02:29         <DIR>    png
  24/12/2013  02:27         <DIR>    resources
  24/12/2013  02:29         <DIR>    svg
  24/12/2013  02:29         <DIR>    svgweb
                   0 bytes in 0 files and 6 dirs
     120.282.697.728 bytes free

  C:\...\svg> \Devel\emacs\repo\trunk\src\emacs.exe -Q svg\color-prof-01-f.svg

  (emacs.exe:10820): Pango-CRITICAL **: No modules found:
  No builtin or dynamically loaded modules were found.
  PangoFc will not work correctly.
  This probably means there was an error in the creation of:
    'C:\Devel\emacs\etc\pango\pango.modules'
  You should create this file by running:
    pango-querymodules > 'C:\Devel\emacs\etc\pango\pango.modules'

  (emacs.exe:10820): Pango-WARNING **: failed to choose a font, expect
ugly output. engine-type='PangoRenderWin32', script='latin'

I'll file it as a bug report in case someone who understands this
stuff wants to work on it.

   J

Re: Please try building with librsvg on MS-Windows

[Stephen J. Turnbull]

Juanma Barranquero writes:

 >    Directory of  C:\Devel\emacs\varios\images\svg\*
 > 
 >   24/12/2013  02:29         <DIR>    harness
 >   24/12/2013  02:29         <DIR>    images
 >   24/12/2013  02:29         <DIR>    png
 >   24/12/2013  02:27         <DIR>    resources
 >   24/12/2013  02:29         <DIR>    svg
 >   24/12/2013  02:29         <DIR>    svgweb
 >                    0 bytes in 0 files and 6 dirs
 >      120.282.697.728 bytes free
 > 
 >   C:\...\svg> \Devel\emacs\repo\trunk\src\emacs.exe -Q svg\color-prof-01-f.svg

Try cd'ing into svg, and running

    \Devel\emacs\repo\trunk\src\emacs.exe -Q color-prof-01-f.svg

 >   (emacs.exe:10820): Pango-CRITICAL **: No modules found:
 >   No builtin or dynamically loaded modules were found.
 >   PangoFc will not work correctly.

It looks like you don't have fontconfig.  That's a question for
somebody else (Eli?) though, as I understand nothing of Windows fonts
except that I can't copy them.

Re: Please try building with librsvg on MS-Windows

[Yuri Khan]

On Tue, Dec 24, 2013 at 12:37 PM, Stephen J. Turnbull
<stephen@xemacs.org> wrote:

>  > Yes, I unzipped the test suite ("SVG 1.1 Second Edition test suite"
>  > from http://www.w3.org/Graphics/SVG/WG/wiki/Test_Suite_Overview) and
>  > it creates the whole test tree. Also, IE and Chrome do show the images
>  > correctly, so the required files are obviously there.
>
> Hm.  What is Emacs's default-directory when you invoke the view
> command?  Maybe that's the problem.

If the default (=current?) directory has anything to do with
resolution of relative references, then it’s a bug. References from
XML documents should be resolved relative to the base URI specified in
the document, or to the URI of the document if the base URI is not
specified.

Re: Please try building with librsvg on MS-Windows

[Juanma Barranquero]

On Tue, Dec 24, 2013 at 3:45 PM, Stephen J. Turnbull <stephen@xemacs.org> wrote:

> Try cd'ing into svg, and running
>
>     \Devel\emacs\repo\trunk\src\emacs.exe -Q color-prof-01-f.svg

I had already tried that, just forgot to report it. It fails in the same way.

   J

Re: Please try building with librsvg on MS-Windows

[Stephen J. Turnbull]

Yuri Khan writes:

 > If the default (=current?) directory has anything to do with
 > resolution of relative references, then it’s a bug.

Indeed.  We know we have a bug, the question is to localize it.

Re: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Tue, 24 Dec 2013 14:19:56 +0100
> Cc: Eli Zaretskii <eliz@gnu.org>, Emacs developers <emacs-devel@gnu.org>
> 
> Running from the root of the test suit:
> 
>   C:\...\svg> dir
> 
>    Directory of  C:\Devel\emacs\varios\images\svg\*
> 
>   24/12/2013  02:29         <DIR>    harness
>   24/12/2013  02:29         <DIR>    images
>   24/12/2013  02:29         <DIR>    png
>   24/12/2013  02:27         <DIR>    resources
>   24/12/2013  02:29         <DIR>    svg
>   24/12/2013  02:29         <DIR>    svgweb
>                    0 bytes in 0 files and 6 dirs
>      120.282.697.728 bytes free
> 
>   C:\...\svg> \Devel\emacs\repo\trunk\src\emacs.exe -Q svg\color-prof-01-f.svg
> 
>   (emacs.exe:10820): Pango-CRITICAL **: No modules found:
>   No builtin or dynamically loaded modules were found.
>   PangoFc will not work correctly.
>   This probably means there was an error in the creation of:
>     'C:\Devel\emacs\etc\pango\pango.modules'
>   You should create this file by running:
>     pango-querymodules > 'C:\Devel\emacs\etc\pango\pango.modules'
> 
>   (emacs.exe:10820): Pango-WARNING **: failed to choose a font, expect
> ugly output. engine-type='PangoRenderWin32', script='latin'
> 
> I'll file it as a bug report in case someone who understands this
> stuff wants to work on it.

Ouch!  That's my bad, sorry: there's a packaging problem with librsvg.

I wish you have waited for me to respond, before submitting a bug
report for something that is not an Emacs problem at all.  But since
you did, I will reply there.

Re: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> From: "Stephen J. Turnbull" <stephen@xemacs.org>
> Cc: Eli Zaretskii <eliz@gnu.org>,
>     Emacs developers <emacs-devel@gnu.org>
> Date: Tue, 24 Dec 2013 23:45:18 +0900
> 
>  >   (emacs.exe:10820): Pango-CRITICAL **: No modules found:
>  >   No builtin or dynamically loaded modules were found.
>  >   PangoFc will not work correctly.
> 
> It looks like you don't have fontconfig.  That's a question for
> somebody else (Eli?) though, as I understand nothing of Windows fonts
> except that I can't copy them.

Eli here.  No, this isn't about fontconfig, because I built Pango
without it: it's not needed on Windows, because Windows can find its
fonts very well, thank you.

The problem was with improper cache files, see my response to the bug
report.

bug#16240: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Tue, 24 Dec 2013 14:19:56 +0100
> Bcc: bug-gnu-emacs@gnu.org

(Why Bcc?  It required me to download the bug report from debbugs, to
have the right headers.  The bug is already filed anyway.)

> Running from the root of the test suit:
> 
>   C:\...\svg> dir
> 
>    Directory of  C:\Devel\emacs\varios\images\svg\*
> 
>   24/12/2013  02:29         <DIR>    harness
>   24/12/2013  02:29         <DIR>    images
>   24/12/2013  02:29         <DIR>    png
>   24/12/2013  02:27         <DIR>    resources
>   24/12/2013  02:29         <DIR>    svg
>   24/12/2013  02:29         <DIR>    svgweb
>                    0 bytes in 0 files and 6 dirs
>      120.282.697.728 bytes free
> 
>   C:\...\svg> \Devel\emacs\repo\trunk\src\emacs.exe -Q svg\color-prof-01-f.svg
> 
>   (emacs.exe:10820): Pango-CRITICAL **: No modules found:
>   No builtin or dynamically loaded modules were found.
>   PangoFc will not work correctly.
>   This probably means there was an error in the creation of:
>     'C:\Devel\emacs\etc\pango\pango.modules'
>   You should create this file by running:
>     pango-querymodules > 'C:\Devel\emacs\etc\pango\pango.modules'
> 
>   (emacs.exe:10820): Pango-WARNING **: failed to choose a font, expect
> ugly output. engine-type='PangoRenderWin32', script='latin'

This is not an Emacs problem, this is a problem in the binary package
for Pango (and perhaps also for librsvg).  The binary distribution for
Pango does include a file etc/pango/pango.modules, but it is empty.
I'm guessing that without any content in that file, Pango looks in the
default place, which is the value of --prefix I used when configured
it.  And you probably didn't install Pango in the same place I did
(d:/usr).  If so, please run the command which is cited in the above
error message, but redirect its output to the place where you have the
pango.modules file, instead of the file name shown in the message.

Similarly, there's a loaders.cache file in the librsvg binary package,
which might need a similar update, using the gdk-pixbuf-query-loaders
command.

Please, before you update these 2 files, try simply removing or
renaming them, and see if that makes the package work without the
error message.  If that doesn't work, create the files with correct
content for your system, and I will then try to find a way to make
installation friendlier (ideally, no need for these files).

bug#16240: Please try building with librsvg on MS-Windows

[Juanma Barranquero]

On Tue, Dec 24, 2013 at 5:51 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> (Why Bcc?

A mistake. I often use Bcc: to send commands to control@debbugs.gnu.org.

> Please, before you update these 2 files, try simply removing or
> renaming them, and see if that makes the package work without the
> error message.

After removing them, Emacs still outputs the error message.

After creating pango.modules the error disappears and Emacs shows the
SVG image with appropriate text (I'm testing with color-prof-01-f.svg
and I see "DRAFT" and "$Revision: 1.9$"). However, the color squares
aren't drawn. Creating loaders.cache does not seem to affect the
result.

     J

bug#16240: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Wed, 25 Dec 2013 03:53:06 +0100
> Cc: Stephen Turnbull <stephen@xemacs.org>, 16240@debbugs.gnu.org
> 
> > Please, before you update these 2 files, try simply removing or
> > renaming them, and see if that makes the package work without the
> > error message.
> 
> After removing them, Emacs still outputs the error message.

Darn!  Thanks for testing.

> After creating pango.modules the error disappears and Emacs shows the
> SVG image with appropriate text (I'm testing with color-prof-01-f.svg
> and I see "DRAFT" and "$Revision: 1.9$"). However, the color squares
> aren't drawn.

That's OK, librsvg seems not to support ICC color profiles that this
test checks.  (And even when the colored squares are shown by Firefox,
the test fails, because the color intensity doesn't change as it
should.)  Besides, any test marked as "DRAFT" is nothing to worry
about, as explained on the W3C site.

> Creating loaders.cache does not seem to affect the result.

So you are saying that removing loaders.cache entirely from the
librsvg archive doesn't affect operation?  If so, I will remove it
from the archive.

Thanks.

bug#16240: Please try building with librsvg on MS-Windows

[Juanma Barranquero]

On Wed, Dec 25, 2013 at 4:55 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> Besides, any test marked as "DRAFT" is nothing to worry
> about, as explained on the W3C site.

Aha.

> So you are saying that removing loaders.cache entirely from the
> librsvg archive doesn't affect operation?

After recreating pango.modules and removing loaders.cache no error is
signaled or output to stderr, and SVG images seem to be displayed
correctly (though I haven't really checked them one by one, just that
a bunch of them display without obvious errors).

     J

bug#16240: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Wed, 25 Dec 2013 03:53:06 +0100
> Cc: Stephen Turnbull <stephen@xemacs.org>, 16240@debbugs.gnu.org
> 
> > Please, before you update these 2 files, try simply removing or
> > renaming them, and see if that makes the package work without the
> > error message.
> 
> After removing them, Emacs still outputs the error message.
> 
> After creating pango.modules the error disappears and Emacs shows the
> SVG image with appropriate text (I'm testing with color-prof-01-f.svg
> and I see "DRAFT" and "$Revision: 1.9$"). However, the color squares
> aren't drawn.

It seems like Pango code already supports what we need: if the file
names in the pango.modules file are relative, not absolute, it looks
for these files in the lib/pango/1.8.0/modules/ subdirectory of where
you unzipped the archive.  Assuming you didn't move the files after
installing them, could you please edit pango.modules, leaving only the
base names of the modules on each line, without any leading
directories, and see if SVG images in the test suite still display
correctly in Emacs?  If that works, I will update the binary archive
with this change, and it should work for everybody else.

(I already tried this on my system, and it worked, but since I install
the packages in the same directory for which they were configured, I
cannot easily make sure it's not the default that works for me.)

> Creating loaders.cache does not seem to affect the result.

loaders.cache have a similar, but slightly different facility: the
file names that appear there _must_ be absolute, and must have the
prefix that was specified at configure time.  Then the
(Windows-specific) code replaces that prefix with the actual root of
the library installation tree.  So that part is already taken care of.

Thanks.

bug#16240: Please try building with librsvg on MS-Windows

[Juanma Barranquero]

On Wed, Dec 25, 2013 at 4:41 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> could you please edit pango.modules, leaving only the
> base names of the modules on each line, without any leading
> directories, and see if SVG images in the test suite still display
> correctly in Emacs?

Yes, they do. Cool.

    J

bug#16240: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Wed, 25 Dec 2013 20:58:50 +0100
> Cc: Stephen Turnbull <stephen@xemacs.org>, 16240@debbugs.gnu.org
> 
> On Wed, Dec 25, 2013 at 4:41 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > could you please edit pango.modules, leaving only the
> > base names of the modules on each line, without any leading
> > directories, and see if SVG images in the test suite still display
> > correctly in Emacs?
> 
> Yes, they do. Cool.

Great, now I know how to fix the binary zips.

Thanks.

bug#16240: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> Date: Wed, 25 Dec 2013 22:16:39 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: stephen@xemacs.org, 16240@debbugs.gnu.org
> 
> > From: Juanma Barranquero <lekktu@gmail.com>
> > Date: Wed, 25 Dec 2013 20:58:50 +0100
> > Cc: Stephen Turnbull <stephen@xemacs.org>, 16240@debbugs.gnu.org
> > 
> > On Wed, Dec 25, 2013 at 4:41 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > 
> > > could you please edit pango.modules, leaving only the
> > > base names of the modules on each line, without any leading
> > > directories, and see if SVG images in the test suite still display
> > > correctly in Emacs?
> > 
> > Yes, they do. Cool.
> 
> Great, now I know how to fix the binary zips.

Done; closing the bug report.

Re: Please try building with librsvg on MS-Windows

[Fabrice Popineau]

Stephen J. Turnbull <stephen <at> xemacs.org> writes:

> 
> Juanma Barranquero writes:
> 
>  > Yes, I unzipped the test suite ("SVG 1.1 Second Edition test suite"
>  > from http://www.w3.org/Graphics/SVG/WG/wiki/Test_Suite_Overview) and
>  > it creates the whole test tree. Also, IE and Chrome do show the images
>  > correctly, so the required files are obviously there.
> 

I upgraded my whole librsvg suite (compile with mingw64).
After moving /usr/local/lib/gdk-pixbuf-2.0 to <emacs_dir>/lib/gdk-pixbuf-2.0 
and /usr/local/etc/pango to <emacs_dir>/etc/pango, I get much better results.

If it still fails for you, what is the file name ?

Fabrice

Re: Please try building with librsvg on MS-Windows

[Eli Zaretskii]

> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Tue, 31 Dec 2013 00:36:41 +0000 (UTC)
> 
> Stephen J. Turnbull <stephen <at> xemacs.org> writes:
> 
> > 
> > Juanma Barranquero writes:
> > 
> >  > Yes, I unzipped the test suite ("SVG 1.1 Second Edition test suite"
> >  > from http://www.w3.org/Graphics/SVG/WG/wiki/Test_Suite_Overview) and
> >  > it creates the whole test tree. Also, IE and Chrome do show the images
> >  > correctly, so the required files are obviously there.
> > 
> 
> I upgraded my whole librsvg suite (compile with mingw64).
> After moving /usr/local/lib/gdk-pixbuf-2.0 to <emacs_dir>/lib/gdk-pixbuf-2.0 
> and /usr/local/etc/pango to <emacs_dir>/etc/pango, I get much better results.
> 
> If it still fails for you, what is the file name ?

The file name was color-prof-01-f.svg.  But the problem was that the
binary archive I prepared included a pango.modules file that mentioned
absolute file names in a specific directory, derived from --prefix
specified at configure time.  Juanma installed librsvg in a different
place, so Pango couldn't find its modules (which are shared libraries)
and load them.

Meanwhile, I found out that keeping the file names in pango.modules
relative, without any leading directories, causes Pango to look for
them in the right place, relative to the root of its installation.  So
I uploaded fixed binary zips to resolve this issue, and it should no
longer exist.

Thanks.