From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#59575: 29.0.50; add-log-current-defun-header-regexp matches Windows drive letter Date: Sun, 27 Nov 2022 12:22:00 +0100 Message-ID: References: <83zgcdsw90.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e9a9ba05ee71f8c8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28417"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59575@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 27 12:23:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozFl5-0007BC-67 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Nov 2022 12:23:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozFkg-00033t-Ff; Sun, 27 Nov 2022 06:23:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozFkY-00032I-Vl for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 06:23:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozFkY-0008SZ-KF for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 06:23:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozFkU-00016P-GK for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 06:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2022 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59575 X-GNU-PR-Package: emacs Original-Received: via spool by 59575-submit@debbugs.gnu.org id=B59575.16695481664219 (code B ref 59575); Sun, 27 Nov 2022 11:23:02 +0000 Original-Received: (at 59575) by debbugs.gnu.org; 27 Nov 2022 11:22:46 +0000 Original-Received: from localhost ([127.0.0.1]:42190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozFkE-00015z-Fs for submit@debbugs.gnu.org; Sun, 27 Nov 2022 06:22:46 -0500 Original-Received: from mail-ej1-f42.google.com ([209.85.218.42]:34549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozFkC-00015q-8P for 59575@debbugs.gnu.org; Sun, 27 Nov 2022 06:22:45 -0500 Original-Received: by mail-ej1-f42.google.com with SMTP id ho10so19586280ejc.1 for <59575@debbugs.gnu.org>; Sun, 27 Nov 2022 03:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d1qKgXPQw54P9ehRRjwNQQAtUbeB4F6aS/X6fZTKGIE=; b=K+Ms8/meTT8gV67bdJGaOdu13AMG3nnFvq6ASjc9uiG24oRzBaOONo1gYxNQMxItRG lFURQ3Iz0qEAaOrWPg9tiZYSHozLqkX98VMa4vyuG0KB9HAOU3B/fZHToTQOrBozGEy3 ELe010B4Zz2cGGxt0N8E8cCYxKmsiVupK/EOBYg99WgjQLuES4jqevaefyHI0HwfhO1T flCNQhLTVAqqZbA4RUz0MJRe98Iq6gktKxyE0azqxXlJ/gtYYWKBpAf695eNtCg5Y5E3 tXaWOHVvtc7jhMHSpnv7x+pIT1BkYI9Zu/wCxchoockfj64/jV6D/XG4+x4ojLErwn7u RcbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d1qKgXPQw54P9ehRRjwNQQAtUbeB4F6aS/X6fZTKGIE=; b=tNp07rg1QNGUsKsqgAxOD/V15eIy8Ixu8uUOIXri5z4w63J5WQpHiU0vB3Y8NpYAqa odQvS9VqMxbIvxukwyxX5Wot4njIlQiVPk5XHrG3uC8mTlvcgWzi66uOciO6ZoRTGzH6 8E3ltfJ5uRWUMIdxPNMoOEQNp7n0I/Sypx7y1b3wTVIS31LnFlelI1k0555n0vCPJI8S 8FmPuDs4UyZWrZSFvCqjH+HHJD22j2pS1v9Fju/0O8kxqs3w3Q3JlgbsbO083GvT6w8E 9rdZwXUrbi6A5iFUzWeehVt+Pgff9I6pacYpvxP5sOG5LBUfJ81loPaQTsbBhWy8rl9u m9ig== X-Gm-Message-State: ANoB5pkS4Ze27XPI8coh2yFbjVxrSN8u4Ys5/n7dvakyZ5F5rX4RFxxO I1IojaOZcVKKM6yhQUZRGuV6YtWdhys7+X76ENc= X-Google-Smtp-Source: AA0mqf5AOUr3AykGPmBwb1rQm/0GLp5OgxdgUPM/WxSpzZdyOgkLM1snBEWVySvrpJ2kw1jBqP8WMjs6fGWfEvpTx/E= X-Received: by 2002:a17:906:2416:b0:7ad:4a55:d6f5 with SMTP id z22-20020a170906241600b007ad4a55d6f5mr40284596eja.220.1669548158329; Sun, 27 Nov 2022 03:22:38 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249199 Archived-At: --000000000000e9a9ba05ee71f8c8 Content-Type: text/plain; charset="UTF-8" On Sun, Nov 27, 2022 at 12:11 PM Juanma Barranquero wrote: > That should be changed to > > (cl-ecase xref-file-name-display > (abs group) > (nondirectory > - (if (string-match-p "\\`~?/" group) > + (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/" group) > (file-name-nondirectory group) > group)) > (project-relative > > or something similar. > Silly me, that should just use `file-name-absolute-p'. OK to fix this, regardless of what's decided for the original bug? --000000000000e9a9ba05ee71f8c8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Nov 27, 2022 at 12:11 PM Juanma Barranquero <lekktu@gmail.com> wrote:
=C2=A0
That should be changed to

=C2= =A0 =C2=A0(cl-ecase xref-file-name-display<= br>=C2=A0 =C2=A0 =C2=A0(abs group)
=C2=A0 =C2=A0 =C2=A0(nondirectory
= - =C2=A0 =C2=A0 (if (string-match-p "\\`~?/" group)
+ =C2=A0 = =C2=A0 (if (string-match-p "\\`\\(~\\|[A-Za-z]:\\)?/" group)
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name-nondirectory group)
=C2=A0= =C2=A0 =C2=A0 =C2=A0 group))
=C2=A0 =C2=A0 =C2=A0(project-relative

or something similar.

Silly me, that should just use `file-name-absolute-= p'.

OK to fix this, regardless of what's decided for the ori= ginal bug?
--000000000000e9a9ba05ee71f8c8--