From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#10164: 24.0.91; Instant crash enabling linum-mode Date: Wed, 30 Nov 2011 13:38:17 +0100 Message-ID: References: <4ED58F60.4000604@code-affinity.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1322656922 16647 80.91.229.12 (30 Nov 2011 12:42:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 30 Nov 2011 12:42:02 +0000 (UTC) Cc: 10164@debbugs.gnu.org, Chong Yidong , Tim Crews To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 30 13:41:56 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RVjTz-0000Gn-FO for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 13:41:51 +0100 Original-Received: from localhost ([::1]:35928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVjSG-0007jq-3u for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Nov 2011 07:40:04 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:35416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVjSC-0007jV-N3 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 07:40:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVjSB-0002SH-PN for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 07:40:00 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVjSB-0002SC-Me for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 07:39:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RVjSE-0006Va-5P for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2011 07:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Nov 2011 12:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10164-submit@debbugs.gnu.org id=B10164.132265674524948 (code B ref 10164); Wed, 30 Nov 2011 12:40:02 +0000 Original-Received: (at 10164) by debbugs.gnu.org; 30 Nov 2011 12:39:05 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVjRI-0006UL-Ah for submit@debbugs.gnu.org; Wed, 30 Nov 2011 07:39:04 -0500 Original-Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVjRF-0006UB-Ug for 10164@debbugs.gnu.org; Wed, 30 Nov 2011 07:39:02 -0500 Original-Received: by ghrr18 with SMTP id r18so575630ghr.3 for <10164@debbugs.gnu.org>; Wed, 30 Nov 2011 04:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=GlbO9OXujBW9ebtYkq0sk2/aVgiRYAtpIunMxQKVlmI=; b=scmqe9c4+yN7tHweCXoRvwI4kT6FJVeDImcxgPmJ7dRKaxmIgmK92xMZUr5WX2u2ch EILXNrxzRJhl6DmwEv1XyJiH+0Moxg7qPICSCrCgT+egtzFX/uekHRH+cB4EiRQrRRgQ 4SR6xau7Ac9+SjsYCFgL0X6XuStOT1ISka+tk= Original-Received: by 10.68.209.9 with SMTP id mi9mr6843837pbc.62.1322656738077; Wed, 30 Nov 2011 04:38:58 -0800 (PST) Original-Received: by 10.142.135.16 with HTTP; Wed, 30 Nov 2011 04:38:17 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 30 Nov 2011 07:40:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54470 Archived-At: On Wed, Nov 30, 2011 at 13:29, Eli Zaretskii wrote: > Chong, I hope this is in time for the next pretest. =C2=A0It would be a > pity to release a pretest with such a glaring problem. But verify_row_hash does nothing except checking and returning a flag, so the new code will never cause an assertion failure... =C2=A0 =C2=A0 Juanma =3D=3D=3D modified file 'src/dispnew.c' --- src/dispnew.c 2011-11-28 01:07:01 +0000 +++ src/dispnew.c 2011-11-30 12:25:09 +0000 @@ -608,9 +608,10 @@ row->glyphs[LAST_AREA] =3D row->glyphs[LEFT_MARGIN_AREA] + dim.width; } - xassert (!row->enabled_p - || row->mode_line_p - || verify_row_hash (row)); +#if XASSERTS + if (row->enabled_p && !row->mode_line_p) + verify_row_hash (row)); +#endif ++row;