From: Juanma Barranquero <lekktu@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 10164@debbugs.gnu.org, Chong Yidong <cyd@gnu.org>,
Tim Crews <tim.crews@code-affinity.com>
Subject: bug#10164: 24.0.91; Instant crash enabling linum-mode
Date: Wed, 30 Nov 2011 13:38:17 +0100 [thread overview]
Message-ID: <CAAeL0SQq-GDb9MLWGqDtJjsBnn3dTvWcBgZaLKksuHwaZ59tiQ@mail.gmail.com> (raw)
In-Reply-To: <E1RVjID-0000ic-Tp@fencepost.gnu.org>
On Wed, Nov 30, 2011 at 13:29, Eli Zaretskii <eliz@gnu.org> wrote:
> Chong, I hope this is in time for the next pretest. It would be a
> pity to release a pretest with such a glaring problem.
But verify_row_hash does nothing except checking and returning a flag,
so the new code will never cause an assertion failure...
Juanma
=== modified file 'src/dispnew.c'
--- src/dispnew.c 2011-11-28 01:07:01 +0000
+++ src/dispnew.c 2011-11-30 12:25:09 +0000
@@ -608,9 +608,10 @@
row->glyphs[LAST_AREA]
= row->glyphs[LEFT_MARGIN_AREA] + dim.width;
}
- xassert (!row->enabled_p
- || row->mode_line_p
- || verify_row_hash (row));
+#if XASSERTS
+ if (row->enabled_p && !row->mode_line_p)
+ verify_row_hash (row));
+#endif
++row;
next prev parent reply other threads:[~2011-11-30 12:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 2:05 bug#10164: 24.0.91; Instant crash enabling linum-mode Tim Crews
2011-11-30 12:19 ` Eli Zaretskii
2011-11-30 12:52 ` Dan Nicolaescu
2011-11-30 13:54 ` Eli Zaretskii
2011-11-30 15:51 ` Dan Nicolaescu
2011-11-30 15:01 ` Andy Moreton
2011-11-30 15:10 ` Juanma Barranquero
2011-11-30 12:29 ` Eli Zaretskii
2011-11-30 12:38 ` Juanma Barranquero [this message]
2011-11-30 13:40 ` Eli Zaretskii
[not found] ` <CAAeL0SS_ydvYGqw0rOd3UR6RoYzJWkEkFhaYX5kZ2m+vTx-Q0w@mail.gmail.com>
[not found] ` <E1RVkfB-00062i-AB@fencepost.gnu.org>
[not found] ` <CAAeL0SRW1A7-vOzNGxFvGtbv=zVSo2ji+_HB7R8rFtq15ufhPg@mail.gmail.com>
2011-11-30 16:24 ` Eli Zaretskii
2011-11-30 16:29 ` Chong Yidong
2011-11-30 16:35 ` Chong Yidong
2011-11-30 16:39 ` Juanma Barranquero
2011-11-30 16:42 ` Chong Yidong
2011-11-30 16:56 ` Eli Zaretskii
2011-11-30 17:37 ` Chong Yidong
2011-11-30 18:10 ` Dan Nicolaescu
2011-11-30 18:29 ` Eli Zaretskii
2011-11-30 18:55 ` Dan Nicolaescu
[not found] ` <handler.10164.D10164.132267227016711.notifdone@debbugs.gnu.org>
2011-11-30 17:29 ` bug#10164: closed (Instant crash enabling linum-mode) Tim Crews
2011-11-30 18:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeL0SQq-GDb9MLWGqDtJjsBnn3dTvWcBgZaLKksuHwaZ59tiQ@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=10164@debbugs.gnu.org \
--cc=cyd@gnu.org \
--cc=eliz@gnu.org \
--cc=tim.crews@code-affinity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.