From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#10578: 24.0.92; No png images on OpenSUSE 12.1 Date: Mon, 23 Jan 2012 02:11:42 +0100 Message-ID: References: <87y5sz1ztp.fsf@linux-hvfx.site> <83k44j3djg.fsf@gnu.org> <83ipk339sj.fsf@gnu.org> <83hazn38tp.fsf@gnu.org> <83fwf731y8.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1327281179 32549 80.91.229.12 (23 Jan 2012 01:12:59 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 23 Jan 2012 01:12:59 +0000 (UTC) Cc: larsi@gnus.org, 10578@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 23 02:12:55 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rp8Ss-0007cp-KA for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Jan 2012 02:12:54 +0100 Original-Received: from localhost ([::1]:37462 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rp8Sr-00080W-VI for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jan 2012 20:12:53 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:47498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rp8Sp-00080G-KF for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2012 20:12:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rp8So-0002RW-EL for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2012 20:12:51 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34966) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rp8So-0002RS-65 for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2012 20:12:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Rp8Sz-0004sQ-L9 for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2012 20:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jan 2012 01:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10578 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10578-submit@debbugs.gnu.org id=B10578.132728116418723 (code B ref 10578); Mon, 23 Jan 2012 01:13:01 +0000 Original-Received: (at 10578) by debbugs.gnu.org; 23 Jan 2012 01:12:44 +0000 Original-Received: from localhost ([127.0.0.1]:40353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rp8Sh-0004ru-1t for submit@debbugs.gnu.org; Sun, 22 Jan 2012 20:12:43 -0500 Original-Received: from mail-pw0-f44.google.com ([209.85.160.44]:62181) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rp8Se-0004rg-HS for 10578@debbugs.gnu.org; Sun, 22 Jan 2012 20:12:41 -0500 Original-Received: by pbcc7 with SMTP id c7so291574pbc.3 for <10578@debbugs.gnu.org>; Sun, 22 Jan 2012 17:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=ZeH6sVVJ4Wr+wKAnmClT8+pTHaG24r9BbXLraH5nOxQ=; b=PF3Lv50v94j0fWGUbW+iPJLusIDg4em34+0rYxZ4jrwNrVy+mHK1HXj0MbCxKEXOFD GcOjTlwZVz7of8PcrL0XzibFQ9KxiimJng6Ys8Nv3tKbL8d/CAtY6sw2mM1b0w8W4EIt +p+qjruXFMYSb3YEci6OyZBUgjfjQ63KtYBPo= Original-Received: by 10.68.75.135 with SMTP id c7mr17728115pbw.43.1327281143172; Sun, 22 Jan 2012 17:12:23 -0800 (PST) Original-Received: by 10.142.149.13 with HTTP; Sun, 22 Jan 2012 17:11:42 -0800 (PST) In-Reply-To: <83fwf731y8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55925 Archived-At: On Sun, Jan 22, 2012 at 21:41, Eli Zaretskii wrote: > How about if you try doing that? The simplest way is just to warn with a fixed message, as in the attached p= atch. If we want to warn with the real message for image_error, either we duplicate the Fformat call in add_to_log, which seems a waste, or we add some function xdisp.c:add_to_log_and_warn. Alternatively, repurposing add_to_log to also (optionally) warn wouldn't be difficult, as it is used only nine times in the sources. In any case, that kind of warning can be intrusive, because display-warning keeps displaying the *Warnings* buffer. For example, if I load libpng12 in a png14-compiled Emacs and visit a PNG file, I get a string of 9 warnings, and 3 more each time I try to advance the cursor. I think it wouldn't be much of a problem with image_error, because the errors are caused by displaying images, and as soon as you kill the corresponding buffer you're OK. =C2=A0 =C2=A0 Juanma =3D=3D=3D modified file 'src/image.c' --- src/image.c 2012-01-19 07:21:25 +0000 +++ src/image.c 2012-01-22 22:22:31 +0000 @@ -676,7 +676,14 @@ static void image_error (const char *format, Lisp_Object arg1, Lisp_Object arg2) { + Lisp_Object warning[3]; + add_to_log (format, arg1, arg2); + warning[0] =3D intern ("image"); + warning[1] =3D build_string ("Image error, please check *Messages*"); + warning[2] =3D intern (":error"); + Vdelayed_warnings_list =3D Fcons (Flist (3, warning), + Vdelayed_warnings_list); }