From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#9722: list-colors-duplicates does not exclude enough colors on Windows Date: Mon, 17 Oct 2011 18:55:05 +0200 Message-ID: References: <834nzfxqq6.fsf@gnu.org> <83aa8zwoyd.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1318870584 20039 80.91.229.12 (17 Oct 2011 16:56:24 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 17 Oct 2011 16:56:24 +0000 (UTC) Cc: 9722@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 17 18:56:16 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqU2-0000if-VY for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Oct 2011 18:56:15 +0200 Original-Received: from localhost ([::1]:50220 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFqU2-0006pe-IX for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Oct 2011 12:56:14 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:60094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFqTz-0006pL-51 for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2011 12:56:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFqTy-0001Up-6S for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2011 12:56:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFqTy-0001Ui-4u for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2011 12:56:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RFqUn-0006Xx-Qn for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2011 12:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Oct 2011 16:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9722 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9722-submit@debbugs.gnu.org id=B9722.131887061325146 (code B ref 9722); Mon, 17 Oct 2011 16:57:01 +0000 Original-Received: (at 9722) by debbugs.gnu.org; 17 Oct 2011 16:56:53 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqUY-0006XR-IW for submit@debbugs.gnu.org; Mon, 17 Oct 2011 12:56:52 -0400 Original-Received: from mail-qy0-f179.google.com ([209.85.216.179]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RFqUU-0006XD-SN for 9722@debbugs.gnu.org; Mon, 17 Oct 2011 12:56:44 -0400 Original-Received: by qyk31 with SMTP id 31so1329058qyk.3 for <9722@debbugs.gnu.org>; Mon, 17 Oct 2011 09:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=iPC8+09m9bhPrCYLysaBwokiKLv0z6YmeRRwbOZ9QIs=; b=w6hCT2Wz0gJrwpeRQJc6pAvcSqJ/nA/ukcYJ7QVYe7TE1C9fuMyAQIKQ9WaN1EMHgl I/Wd5oO18B/1ni++bfLjdiOCtwtdNgQQP1kNqP/eYIkbe2KJCQWhGwzbRcrXlUfXIMDv /23igm2iEJmCOen9UTXKs5r4Fpxat26oDt6AI= Original-Received: by 10.68.0.227 with SMTP id 3mr39417340pbh.48.1318870545055; Mon, 17 Oct 2011 09:55:45 -0700 (PDT) Original-Received: by 10.143.165.16 with HTTP; Mon, 17 Oct 2011 09:55:05 -0700 (PDT) In-Reply-To: <83aa8zwoyd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 17 Oct 2011 12:57:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52728 Archived-At: On Mon, Oct 17, 2011 at 18:41, Eli Zaretskii wrote: > It doesn't sound TRT to me to use w32-default-color-map for the > purpose of retaining some special colors in the list. I doesn't seem TRT to me either. My proposed patch removed that dependency. In fact, I believe that w32-default-color-map should be declared obsolete, to be turned into an internal-only function in some future release. There's no real point to have it exposed to elisp, other than using it in list-colors-duplicates. > =C2=A0I think it > would be cleaner to have a separate (much shorter) list of colors that > should not be removed even if their RGB values are identical to other > colors already present in the list produced by defined-colors. We can add that list, but currently, only colors named System.* are in that category. Checking for "^System" or populating that list are both very ad hoc fixes for a very specific Windows problem. > If you agree, let's create such a list, put it on w32-fns.el, and use > it in facemenu.el. > > OK? I'm not sure. Pros: - The new list could be expanded by the user (if exposed to elisp as a list and not a function) - It does not depend on the reserved colors all being called System.* Contras: - It does not remove the need for w32_color_map / Fw32_default_color_map, because these have another use (default color list in case etc/rgb.txt is not found). - It adds a new function or variable and a bit of complexity, for what is just filtering out a few colors. =C2=A0 =C2=A0 Juanma