From: Juanma Barranquero <lekktu@gmail.com>
To: Eric Raymond <esr@thyrsus.com>
Cc: Bastien <bzg@gnu.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names.
Date: Thu, 9 Jan 2014 13:48:39 +0100 [thread overview]
Message-ID: <CAAeL0SQVqq4GbqSZ_VKYuWpq6ikkr_NJgJU=eV8F2_q=MkGfFg@mail.gmail.com> (raw)
In-Reply-To: <20140109123702.GB5361@thyrsus.com>
On Thu, Jan 9, 2014 at 1:37 PM, Eric S. Raymond <esr@thyrsus.com> wrote:
> I must be missing something. I don't see how this would solve any problem
> at all.
It's no different of any other change that obsoletes a variable. Old
code uses it, even if there's newer code with improved features.
> I don't understand why simply looking at emacs-bzr-version isn't working
> for you, given that it's now aliased.
It is working (at least, the part that does not call
emacs-bzr-get-version, which does not exist anymore). I'm saying that
my previous suggestion of defining an obsolete alias is wrong, because
the old and the new variables are NOT compatible.
> What would (emacs-bug) look at under this plan? If your answer is
> emacs-bzr-version, I strongly object.
Currently? emacs-bzr-version. After the switch? Whatever you want.
> The fact that the VCS name
> was exposed at that level was a *bug*, a layering violation (and I would
> say the same thing if the name had been emacs-git-version). Nothing
> in Lisp outside version.el has need to know that and therefore
> should not know it.
That it is a layering violation is a matter of opinion. That is was
documented as having a specific structure is a fact, and that at least
one person in the universe (though perhaps more, as it has been
available since 24.3, almost a year ago) is using it, is another fact.
These aren't up for discussion. I understand that you feel strongly
about how that API should be, and I'm not opposing your changes in the
future. But I don't accept that you have the right to rewrite the past
and just *remove* a published API because you think it is wrong
(*even* if you're right) when we have a perfectly clear mechanism to
deal with such situations, named obsolescence.
> I don't see any win at all in this reversion. And because doing it would
> reintroduce a layering violation, I'm going to need a lot of convincing.
Why should I have to convince you that you shouldn't remove published
APIs? I don't want to turn this into a silly commit battle, but if you
don't fix it in a compatible way, I will. I'm only asking that your
changes for the future (need I to remind you that we're still using
Bazaar?) do not break anything that does not *need* to be broken.
J
next prev parent reply other threads:[~2014-01-09 12:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1W124t-0007MM-P3@vcs.savannah.gnu.org>
2014-01-08 23:18 ` trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names Glenn Morris
2014-01-08 23:34 ` Eric S. Raymond
2014-01-08 23:57 ` Juanma Barranquero
2014-01-09 0:04 ` Eric S. Raymond
2014-01-09 0:06 ` Daniel Colascione
2014-01-09 0:12 ` Eric S. Raymond
2014-01-09 0:13 ` Daniel Colascione
2014-01-09 0:09 ` Bastien
2014-01-09 0:27 ` Eric S. Raymond
2014-01-09 0:43 ` Juanma Barranquero
2014-01-09 1:25 ` Eric S. Raymond
2014-01-09 1:31 ` Juanma Barranquero
2014-01-09 2:13 ` Juanma Barranquero
2014-01-09 5:27 ` Eric S. Raymond
2014-01-09 9:36 ` Juanma Barranquero
2014-01-09 12:37 ` Eric S. Raymond
2014-01-09 12:48 ` Juanma Barranquero [this message]
2014-01-09 13:13 ` Eric S. Raymond
2014-01-09 13:27 ` Juanma Barranquero
2014-01-09 13:47 ` Eric S. Raymond
2014-01-09 14:05 ` Juanma Barranquero
2014-01-09 14:29 ` Eric S. Raymond
2014-01-09 14:45 ` Juanma Barranquero
2014-01-09 15:08 ` Eric S. Raymond
2014-01-09 15:21 ` Juanma Barranquero
2014-01-09 20:43 ` chad
2014-01-09 12:00 ` Rüdiger Sonderfeld
2014-01-09 12:12 ` Juanma Barranquero
2014-01-09 12:20 ` Rüdiger Sonderfeld
2014-01-09 12:24 ` Juanma Barranquero
2014-01-09 0:10 ` Juanma Barranquero
2014-01-09 3:48 ` Stephen J. Turnbull
2014-01-09 0:34 ` Glenn Morris
2014-01-09 6:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeL0SQVqq4GbqSZ_VKYuWpq6ikkr_NJgJU=eV8F2_q=MkGfFg@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=bzg@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.