From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500) Date: Wed, 14 Nov 2012 17:19:58 +0100 Message-ID: References: <87haoyl4on.fsf@topper.koldfront.dk> <87625bw1jx.fsf@visionobjects.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1352913336 4737 80.91.229.3 (14 Nov 2012 17:15:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Nov 2012 17:15:36 +0000 (UTC) Cc: asjo@koldfront.dk, ivan.kanis@googlemail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Katsumi Yamaoka Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 14 18:15:45 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TYgYw-00038U-EH for ged-emacs-devel@m.gmane.org; Wed, 14 Nov 2012 18:15:42 +0100 Original-Received: from localhost ([::1]:47552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYfho-0000mN-Mh for ged-emacs-devel@m.gmane.org; Wed, 14 Nov 2012 11:20:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYfhi-0000Z1-RT for emacs-devel@gnu.org; Wed, 14 Nov 2012 11:20:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYfhf-0007MW-OS for emacs-devel@gnu.org; Wed, 14 Nov 2012 11:20:42 -0500 Original-Received: from mail-ee0-f41.google.com ([74.125.83.41]:64487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYfhf-0007MP-Hz for emacs-devel@gnu.org; Wed, 14 Nov 2012 11:20:39 -0500 Original-Received: by mail-ee0-f41.google.com with SMTP id d41so462914eek.0 for ; Wed, 14 Nov 2012 08:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=iOEPGQc5sg1+QR7XZM7jXuWZu2egMPR5mcmAtd4LqJU=; b=RHUfgBqfValU6I6UbMPRhFrboO/sMYkZWlw4KoCPoEzdgAd/dPK2uff6/eQDEYftY+ e/MaEi9QLlz7sW0GVNtTQmGlAY+ZTlquDgm+bgMr4uLVSQmY78BwJf5EahDNgjAN32sr M+ENhrAFsie5yc8pmlHfKuDtPXlg5gHqjyYX2wjauDX2oD5o/gpzb0fhf1XNBsTMC6M1 UVUbvz3X4BCWj0QevDlzvyFG2mj3rVR1t5DUHi8hgGrfZOjFHlUuFvjOXdC0kEFbAF5V 9CVjTojby7SOMXthbT+OQDtD45HUu3c30/OIaipm+OrQEtIB5GzhbQENT3DUu4LihQf9 TiTw== Original-Received: by 10.14.173.71 with SMTP id u47mr88286322eel.20.1352910038411; Wed, 14 Nov 2012 08:20:38 -0800 (PST) Original-Received: by 10.223.4.209 with HTTP; Wed, 14 Nov 2012 08:19:58 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154861 Archived-At: On Wed, Nov 14, 2012 at 12:18 AM, Katsumi Yamaoka wrote: > In the latter case I got the following error: > > Debugger entered--Lisp error: (wrong-type-argument listp t) > ad-parse-arglist(t) > ad-map-arglists(t t) > ad-make-advised-definition(gnus-article-prepare-display) > ad-activate-advised-definition(gnus-article-prepare-display nil) > ad-activate(gnus-article-prepare-display nil) > (progn (ad-add-advice (quote gnus-article-prepare-display)... I'm getting this one in advices for functions that aren't yet loaded, when the advice uses "activate". Easy to see here: emacs -Q (defadvice ada-mode (before my-ada activate) t) Which is perhaps a mistake, but it was previously silently ignored. Juanma