From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] fix goto-line Date: Fri, 29 Jul 2011 13:22:31 +0200 Message-ID: References: <874o26muk2.fsf@gnu.org> <8762ml5odm.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1311938600 5492 80.91.229.12 (29 Jul 2011 11:23:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 29 Jul 2011 11:23:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 29 13:23:16 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qml9v-0000cu-QX for ged-emacs-devel@m.gmane.org; Fri, 29 Jul 2011 13:23:15 +0200 Original-Received: from localhost ([::1]:53239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qml9v-0006Nw-8L for ged-emacs-devel@m.gmane.org; Fri, 29 Jul 2011 07:23:15 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:42413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qml9s-0006NR-Pn for emacs-devel@gnu.org; Fri, 29 Jul 2011 07:23:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qml9r-0004xY-Su for emacs-devel@gnu.org; Fri, 29 Jul 2011 07:23:12 -0400 Original-Received: from mail-qy0-f169.google.com ([209.85.216.169]:38284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qml9r-0004x1-Kl for emacs-devel@gnu.org; Fri, 29 Jul 2011 07:23:11 -0400 Original-Received: by qyk32 with SMTP id 32so4054489qyk.0 for ; Fri, 29 Jul 2011 04:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=YHLJESVI7Om9VGCT4El3Wu/NOqYK5pniwAImBgI6erI=; b=dcY7MhKF9Qj6QGPB9LEd0ez1NKlU6f+wSdXtLI5sQ0xRDaLly+r65RhUe/cuToptVa uQczCUxPL/MurJAOye/ULXwBPa4s/FzIrcr3uq/EPAWcnoU664Or2Q7s/2uovtarrkyR 8q9t4ZVV3BaDFireJ+WFQ+cvfsyk2kFho5GYA= Original-Received: by 10.229.99.203 with SMTP id v11mr849868qcn.244.1311938591048; Fri, 29 Jul 2011 04:23:11 -0700 (PDT) Original-Received: by 10.229.95.134 with HTTP; Fri, 29 Jul 2011 04:22:31 -0700 (PDT) In-Reply-To: <8762ml5odm.fsf@mail.jurta.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.216.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:142485 Archived-At: On Fri, Jul 29, 2011 at 13:15, Juri Linkov wrote: > I noticed the following areas for improvement: > > 1. `read-number' already inserts the default value into prompt. > =C2=A0 So the same code is not necessary in `goto-line'. > > 2. It would be useful to add the current line number to the defaults > =C2=A0 of `goto-line' to allow its easier modification by users. There are improvements and not bug fixes, so please file this as a wishlist item for 24.2 (and do not forget to add the "patch" tag). =C2=A0 =C2=A0 Juanma