From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500) Date: Fri, 16 Nov 2012 18:36:19 +0100 Message-ID: References: <87haoyl4on.fsf@topper.koldfront.dk> <87625bw1jx.fsf@visionobjects.com> <87pq3fxmta.fsf@googlemail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1353087428 21751 80.91.229.3 (16 Nov 2012 17:37:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Nov 2012 17:37:08 +0000 (UTC) Cc: Katsumi Yamaoka , ivan.kanis@googlemail.com, asjo@koldfront.dk, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 16 18:37:19 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TZPqw-0001U8-IQ for ged-emacs-devel@m.gmane.org; Fri, 16 Nov 2012 18:37:18 +0100 Original-Received: from localhost ([::1]:50093 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZPqm-0005Ja-Ls for ged-emacs-devel@m.gmane.org; Fri, 16 Nov 2012 12:37:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZPqi-0005J4-4L for emacs-devel@gnu.org; Fri, 16 Nov 2012 12:37:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZPqf-0008BX-2A for emacs-devel@gnu.org; Fri, 16 Nov 2012 12:37:04 -0500 Original-Received: from mail-ee0-f41.google.com ([74.125.83.41]:60834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZPqe-0008BG-S5 for emacs-devel@gnu.org; Fri, 16 Nov 2012 12:37:00 -0500 Original-Received: by mail-ee0-f41.google.com with SMTP id d41so2096187eek.0 for ; Fri, 16 Nov 2012 09:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=FFamaErJsH6gnUOW4AGYRq+HNGppoASi8SHpOgCgNqA=; b=riO5EA/2AwRGqq9rEvnwkqnsp5gMrQxZAIMDnYHCWuSxejC1k9rDHm5dtGczdMXVy8 h/mFyRBfP9oQWaNouTrg07AEDv1F57Ma151d0mJmNdTSrWlLnwbOerLwTajfNaUrOzoV XOlSm0JZKBlkLKNC2Jg+EOVAXKmxWuRezKVB434OiMTW1IHxcJiTU6mTQCkOY8UAQ1mh 0w4uyRElTqLutCXE6fsYkFs0utnLDNa/lvRiFHLgemhWdll35EtHCK0t91kKgZ50wKO/ TCz0yNyPTLFAxU4+g0L8pPZfOckOQcTRu5zq1SLEdN4qBwC63tz7URGoH9P4r1H8+GZ3 sXQA== Original-Received: by 10.14.213.65 with SMTP id z41mr15317393eeo.29.1353087420029; Fri, 16 Nov 2012 09:37:00 -0800 (PST) Original-Received: by 10.223.4.209 with HTTP; Fri, 16 Nov 2012 09:36:19 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154884 Archived-At: On Fri, Nov 16, 2012 at 6:25 PM, Stefan Monnier wrote: > Hmm... maybe advice-add's before and after advices should be different. > Instead of before being like > (lambda (&rest r) (apply FUNCTION r) (apply OLDFUN r)) > it should maybe be like > (lambda (&rest r) (apply OLDFUN (apply FUNCTION r))) > Or maybe this should be a new WHERE, which we could call `:filter-args', > and we could have a corresponding `:filter-return'. Well, having new WHEREs seems more flexible, assuming that :filter-args is indeed the right thing to do for all "before" defadvices. Juanma