From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Date: Thu, 27 Feb 2014 16:32:09 +0100 Message-ID: References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1393515189 29231 80.91.229.3 (27 Feb 2014 15:33:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Feb 2014 15:33:09 +0000 (UTC) Cc: Nicolas Richard , 16816@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 27 16:33:16 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WJ2xY-0002Pl-Gz for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Feb 2014 16:33:16 +0100 Original-Received: from localhost ([::1]:46594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ2xY-0008Nl-5d for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Feb 2014 10:33:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ2xQ-0008MW-7g for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2014 10:33:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ2xL-00087y-GG for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2014 10:33:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ2xL-00087t-D9 for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2014 10:33:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WJ2xL-000752-12 for bug-gnu-emacs@gnu.org; Thu, 27 Feb 2014 10:33:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2014 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.139351517327180 (code B ref 16816); Thu, 27 Feb 2014 15:33:02 +0000 Original-Received: (at 16816) by debbugs.gnu.org; 27 Feb 2014 15:32:53 +0000 Original-Received: from localhost ([127.0.0.1]:42823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ2xA-00074J-On for submit@debbugs.gnu.org; Thu, 27 Feb 2014 10:32:53 -0500 Original-Received: from mail-yh0-f41.google.com ([209.85.213.41]:36641) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ2x8-00074A-8H for 16816@debbugs.gnu.org; Thu, 27 Feb 2014 10:32:51 -0500 Original-Received: by mail-yh0-f41.google.com with SMTP id f73so2822067yha.14 for <16816@debbugs.gnu.org>; Thu, 27 Feb 2014 07:32:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=LwL58avzLvUjMk9yq59H9r1qmGoafFmlFnWsKwOXjMU=; b=PSK1gH0XM6iGL6mh5utMz9XZipCVIoI2hTi8jd+OqAYVBCSyXtNhYxv4WYqXIyZ1PN ye6DtwE++xchJgTmt+XrXvHxufGB7O5VyiNf+ZR67lvVjHKfOR29996KZcqTB2Q0iL7s DyRFb278n/S0qkcKog2EJ4sE4ReGM5dwUdppwVYWcS1MSBzI5/mff2Eh62TdaZ9qcB1/ lgC9/MGVEqaoZyREefChOgtJ4u7e1t3ub0oinflSR0XOcT6pqlJ6RpizT3vqW5HbZcmb JgWLhaMPVEJNVehK7qMuJ1LPmrAqq+IbWfCa4gzRSSNZnLev7prKdtzFah2WJwfBOmGi zhSg== X-Received: by 10.236.122.99 with SMTP id s63mr15825407yhh.19.1393515169585; Thu, 27 Feb 2014 07:32:49 -0800 (PST) Original-Received: by 10.170.197.1 with HTTP; Thu, 27 Feb 2014 07:32:09 -0800 (PST) In-Reply-To: <53074FDB.4040907@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86305 Archived-At: reopen 16816 quit On Fri, Feb 21, 2014 at 2:08 PM, martin rudalics wrote: > `with-temp-buffer-window' should behave as `with-output-to-temp-buffer' > in this regard (at least I hope so). So in revision 116509 I moved the > evaluation of BODY out of the scope of `with-current-buffer'. If this > causes problems, I will revert and use your patch. This breaks with-help-window. Try emacs -Q C-x C-h the help output is inserted in the current buffer (*scratch*, in this case). This patch fixes it. === modified file 'lisp/help.el' --- lisp/help.el 2014-02-10 01:34:22 +0000 +++ lisp/help.el 2014-02-27 15:29:05 +0000 @@ -1207,7 +1207,8 @@ (temp-buffer-window-show-hook (cons 'help-mode-finish temp-buffer-window-show-hook))) (with-temp-buffer-window - ,buffer-name nil 'help-window-setup (progn ,@body))))) + ,buffer-name nil 'help-window-setup + (with-current-buffer ,buffer-name ,@body))))) ;; Called from C, on encountering `help-char' when reading a char. ;; Don't print to *Help*; that would clobber Help history.