From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names. Date: Thu, 9 Jan 2014 03:13:01 +0100 Message-ID: References: <56y52qcbbh.fsf@fencepost.gnu.org> <20140108233424.GA15258@thyrsus.com> <20140109000406.GA22775@thyrsus.com> <87mwj6f23d.fsf@bzg.ath.cx> <20140109002754.GA22950@thyrsus.com> <20140109012554.GA23333@thyrsus.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1389233630 15089 80.91.229.3 (9 Jan 2014 02:13:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jan 2014 02:13:50 +0000 (UTC) Cc: Bastien , Emacs developers To: Eric Raymond Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 09 03:13:55 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W1586-000065-F0 for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 03:13:54 +0100 Original-Received: from localhost ([::1]:49795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1586-0003BR-0u for ged-emacs-devel@m.gmane.org; Wed, 08 Jan 2014 21:13:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W157y-0003Af-7m for emacs-devel@gnu.org; Wed, 08 Jan 2014 21:13:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W157x-0005QJ-FR for emacs-devel@gnu.org; Wed, 08 Jan 2014 21:13:46 -0500 Original-Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:42163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W157w-0005Q1-3S; Wed, 08 Jan 2014 21:13:44 -0500 Original-Received: by mail-ee0-f51.google.com with SMTP id b15so1037060eek.38 for ; Wed, 08 Jan 2014 18:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wi9pJDtqXPmEmUnfVV2NeAsyBgP88IloKkELGmPyBwk=; b=qN+aYWmS8gPHT2CxEU0BtBZ3VWwG8bFcOT4mK8I+gKD5y97uVNd+yIfPgQMhwDv30d /EUqrjgaMht81tmOz88gQShl6FOV/71p0JHFkSE5rcfIUpaqsdY35LCyVN8KhSAzJmng HZbzeiU2LU0fIKqyAK0bn+P4fjPjJ99VTfDmz7gsqbo7Ah5zHR2EE3OFutMHY48SIsKJ IVOxsWv8aJwEEotF+aEtFtJ8HhjtEFA1c+Youg5gZfboVirLtB636aBcvA9p6wZkJU7b n1IEqL+3Po/70LztpTsHpJx06FZoV9Ri8NDxZHrpoLwg+/aB7z+BuClCIao5CnXsfnd5 /BMQ== X-Received: by 10.15.91.3 with SMTP id r3mr515431eez.18.1389233621464; Wed, 08 Jan 2014 18:13:41 -0800 (PST) Original-Received: by 10.14.209.69 with HTTP; Wed, 8 Jan 2014 18:13:01 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167848 Archived-At: On second thought, I'm not so sure that renaming emacs-bzr-version and emacs-bzr-get-version is a good idea (though I agree with your other changes, to remove Bazaar-specific references in docs, etc.) The reason is that emacs-repository-version and emacs-repository-get-version won't be true replacements for the current variable and function. They won't contain or return data in the same format, and I won't be able, for example, to just use emacs-repository-version in the same way I'm using emacs-bzr-version right now. It's not possible, because I'm using the fact that their value started with a numerical revno (I'm doing arithmetic with that value), which does not make sense in Git. I will be forced to change my code, so just making emacs-bzr-version into an obsolete alias of emacs-repository-version is misleading. IMO it would make more sense to define new emacs-git-version and emacs-git-get-version instances and let user code sort which one needs to use. These function and variable are never going to be really repository- or DVCS-independent anyway. And it's not like we're likely to switch DVCS again in a few years... J