all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: 10851@debbugs.gnu.org
Subject: bug#10851: Error edebugging read-char-by-name
Date: Mon, 20 Feb 2012 13:52:59 +0100	[thread overview]
Message-ID: <CAAeL0SQ8JFLWnHzOrCv2fGBYOUTt6-LmnwoszyvgLp+OMsXa4A@mail.gmail.com> (raw)
In-Reply-To: <CAAeL0SSr_DK=j-4uWob8ynQORiLWXM1gQzV2BuQMSZm8ErfdYQ@mail.gmail.com>

The initial analysis by Martin:

"In `edebug-pop-to-buffer' the following
branch is taken in both versions:

        ((one-window-p 'nomini)
         ;; When there's one window only, split it.
         (split-window))

The difference between 23.4 and 24.1 lies in the fact that with 23.4 the
selected window is the frame's root window while with 24.1 the selected
window is the minibuffer window.  Now asking to split the minibuffer
window is surely wrong, so `edebug-pop-to-buffer' should check that case
anyway.  But we should be able to find out which change is responsible
for calling `edebug-pop-to-buffer' with the minibuffer window selected.

FWIW this is due to the following change in `read-char-by-name' which
instead of

        (input (completing-read prompt ucs-completions)))

now does

        (input (completing-read
                prompt
                (lambda (string pred action)
                  (if (eq action 'metadata)
                      '(metadata (category . unicode-name))
                    (complete-with-action action (ucs-names) string pred))))))

and here I suppose (I didn't check) that we enter `complete-with-action'
and somehow change the selected window under the feet of edebug."





  reply	other threads:[~2012-02-20 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-20 12:49 bug#10851: Error edebugging read-char-by-name Juanma Barranquero
2012-02-20 12:52 ` Juanma Barranquero [this message]
2012-10-06 12:57 ` martin rudalics
2012-10-07  0:47   ` Juanma Barranquero
2012-10-08  6:56     ` martin rudalics
2012-10-08 11:17       ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAeL0SQ8JFLWnHzOrCv2fGBYOUTt6-LmnwoszyvgLp+OMsXa4A@mail.gmail.com \
    --to=lekktu@gmail.com \
    --cc=10851@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.