bug#20839: 25.0.50; file-in-directory-p doesn't understand windows backslashes

bug#20839: 25.0.50; file-in-directory-p doesn't understand windows backslashes

[Artur Malabarba]

On windows, the following form returns nil, but I think it should
return non-nil (\\ and / are usually accepted interchangeably on
windows).

    (file-in-directory-p "~/.emacs.d/elpa/magit/" "~\\.emacs.d\\elpa")

This is causing an issue[1] on the package.el's detection of external
packages on windows.

[1]: http://emacs.stackexchange.com/q/13166/50

bug#20839: 25.0.50; file-in-directory-p doesn't understand windows backslashes

[Eli Zaretskii]

> Date: Wed, 17 Jun 2015 19:58:18 +0100
> From: Artur Malabarba <arturmalabarba@gmail.com>
> 
> On windows, the following form returns nil, but I think it should
> return non-nil (\\ and / are usually accepted interchangeably on
> windows).
> 
>     (file-in-directory-p "~/.emacs.d/elpa/magit/" "~\\.emacs.d\\elpa")

This returns t for me, so I'm unsure what kind of problems are here.

bug#20839: 25.0.50; file-in-directory-p doesn't understand windows backslashes

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

Sorry for the noise then.
I was aiding someone remotely and I assumed this was the issue. I'll ask
them to file a bug report themselves.

Artur

[-- Attachment #2: Type: text/html, Size: 187 bytes --]

bug#20839: 25.0.50; file-in-directory-p doesn't understand windows backslashes

[Eli Zaretskii]

> Date: Wed, 17 Jun 2015 21:13:13 +0100
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: 20839@debbugs.gnu.org
> 
> I was aiding someone remotely and I assumed this was the issue. I'll ask them
> to file a bug report themselves. 

Yes, please.

Just FYI, a call to file-truename or expand-file-name converts all
backslashes into forward slashes.  And file-in-directory-p calls
file-truename on both its arguments.  So the favor of the slashes
cannot possibly be the culprit here, at least not in this simple way.

bug#20839: 25.0.50; file-in-directory-p doesn't understand windows backslashes

[Eli Zaretskii]

> Date: Wed, 17 Jun 2015 21:13:13 +0100
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: 20839@debbugs.gnu.org
> 
> I was aiding someone remotely and I assumed this was the issue. I'll ask them
> to file a bug report themselves. 

I see no bug report, and I suspect the user might be contempt with the
"sledgehammer" (their word) solution mentioned there, and so that
report will never materialize.  Should we close this bug?

Meanwhile, the offending line cited there, viz.:

  ((not (file-in-directory-p dir package-user-dir)) "external")

has one more unknown, as far as I'm concerned: the value of 'dir'.
That comes from this, AFAICS:

  (package-desc-dir pkg-desc)

So it would e nice if the value that comes out of that on that user's
system could be reported.

Also, could any of the other packages that user loads overload the
functions involved in calculating file-in-directory-p?

Those are the ideas I had, anyway.

bug#20839: 25.0.50; file-in-directory-p doesn't understand windows backslashes

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

On Jun 18, 2015 9:31 AM, "Eli Zaretskii" <eliz@gnu.org> wrote:
>
> > Date: Wed, 17 Jun 2015 21:13:13 +0100
> > From: Artur Malabarba <bruce.connor.am@gmail.com>
> > Cc: 20839@debbugs.gnu.org
> >
> > I was aiding someone remotely and I assumed this was the issue. I'll
ask them
> > to file a bug report themselves.
>
> I see no bug report,

Well, it's been only 13h. :-)

> and I suspect the user might be contempt with the
> "sledgehammer" (their word) solution mentioned there, and so that
> report will never materialize.

Actually, he's been responding to my questions even after posting his
solution, so he's probably willing to help.

>Should we close this bug?

Yes. We should close it anyway. I was just going to tell him to M-x
report-emacs-bug, so that would be a new report anyway.

> has one more unknown, as far as I'm concerned: the value of 'dir'.
> That comes from this, AFAICS:
>
>   (package-desc-dir pkg-desc)
>
> So it would e nice if the value that comes out of that on that user's
> system could be reported.

I think it's the same value you get on the package description buffer, but
I can't check ATM (floor closed off as a fire hazard).
In any case, we can give him an advice to report that value if he files a
report.

> Also, could any of the other packages that user loads overload the
> functions involved in calculating file-in-directory-p?

Well, this *is* emacs.

[-- Attachment #2: Type: text/html, Size: 1966 bytes --]

bug#20839: 25.0.50; file-in-directory-p doesn't understand windows backslashes

[Eli Zaretskii]

> Date: Thu, 18 Jun 2015 11:03:14 +0100
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: 20839@debbugs.gnu.org
> 
> >Should we close this bug?
> 
> Yes.

Done.