From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: autoload for eww-suggest-uris Date: Thu, 5 Mar 2015 18:55:57 -0300 Message-ID: References: <20150216190531.25142.72090@vcs.savannah.gnu.org> <87bnks8j14.fsf_-_@violet.siamics.net> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1425592638 21872 80.91.229.3 (5 Mar 2015 21:57:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Mar 2015 21:57:18 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 05 22:57:18 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YTdke-0002jG-4N for ged-emacs-devel@m.gmane.org; Thu, 05 Mar 2015 22:56:16 +0100 Original-Received: from localhost ([::1]:55131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTdkd-0002KD-Fq for ged-emacs-devel@m.gmane.org; Thu, 05 Mar 2015 16:56:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTdkO-0002H0-DJ for emacs-devel@gnu.org; Thu, 05 Mar 2015 16:56:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTdkN-0003J8-7Q for emacs-devel@gnu.org; Thu, 05 Mar 2015 16:56:00 -0500 Original-Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:40658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTdkM-0003I3-Ng for emacs-devel@gnu.org; Thu, 05 Mar 2015 16:55:59 -0500 Original-Received: by lbiw7 with SMTP id w7so14676420lbi.7 for ; Thu, 05 Mar 2015 13:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type:content-transfer-encoding; bh=ZWA+ZOwukyItBVoi2OE2opmP2mlYwAPCwIlZ3X9tqWg=; b=V6DugYcGWjipHtNtSz4+6z7yZwpIqIV+5cf1MROyA1DQIbngmPTEC0iZ9gpUJWzMkh 5V6mR3t5JwZt8n/Bgz9ADkHTO+dXXgDbA92CFgY3NI0mo4VGzL7Iru39lnxat9/aBFF+ 0FcuMlKT6NW5tkOrjPIiJhBZhE0gjvVGVJydCtiS0X4L/4cVacuIcWQn75fSQ8fXP/5V EtotC0q7vSQU/+j040rk+fOqnE9GS2iFKz+HuZBLS/U7Dsbt4CnoOsky/PtYdeMnL8FG kQKPoLq9W2BuxJ3MIvXiS2gGsHPebQIF3RMgAXD/xIjCaJZe5FBT4MXCky+u2lMOyy4+ M0JA== X-Received: by 10.112.140.74 with SMTP id re10mr10114459lbb.80.1425592557442; Thu, 05 Mar 2015 13:55:57 -0800 (PST) Original-Received: by 10.112.207.225 with HTTP; Thu, 5 Mar 2015 13:55:57 -0800 (PST) In-Reply-To: <87bnks8j14.fsf_-_@violet.siamics.net> X-Google-Sender-Auth: -mWyPOmxBfJaiL5CzdyCBE7pBko X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183684 Archived-At: > > Personally, I'd recommend finding another way around your add-hook > > issue. What was the problem? > > This: > > ;;; ~/.emacs > (add-hook 'eww-suggest-uris 'some-new-function) > ; =E2=86=92 (some-new-function) > > Expected: that some-new-function /and/ all the default ones. > > An alternative would be to use add-hook in 'eww itself, but that > in turn interferes with (setq eww-suggest-uris '(the-only-one)). According to Stefan it is a bug to define a hook with a non-nil initial value (see http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg01271.html), so using the `add-hook' in eww itself is the correct way. In fact, it seems that 25.1 will issue a compiler warning when a hook variable is given a non-nil initial value.