all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: "Taylan Ulrich Bayırlı/Kammer" <taylanbayirli@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [PATCH] Add file-dwim.
Date: Sun, 18 Oct 2015 20:12:27 +0100	[thread overview]
Message-ID: <CAAdUY-LW9CRQRkRziSRtGTMDuRj=Mc3ZUrGhs5TS6QREGxxVWA@mail.gmail.com> (raw)
In-Reply-To: <87d1wcrzuu.fsf@T420.taylan>

> +  :group 'file-dwim)

These :group entries are redundant. It is a (poorly documented)
feature that all defcustoms following a defgroup belong to that
defgroup.

> +;; (defun play-video-file (file)
> +;;   (shell-command (concat "my-video-player " (shell-quote-argument file))))

Why not say that the cdr of an entry in `file-dwim-action-list' can
also be a list like ("command" "arg1" "arg2"), in which case it used
in `start-process' with the file-name at the end?
For instance:

    (add-to-list 'file-dwim-action-list
                 (list (rx "." (or "mp3" "flac" "aac" "wav") eos) "mplayer"))

I think that would be very valuable, as this sounds like the common
use for this package.



  reply	other threads:[~2015-10-18 19:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18 14:54 [PATCH] Add file-dwim Taylan Ulrich Bayırlı/Kammer
2015-10-18 19:12 ` Artur Malabarba [this message]
2015-10-18 19:46   ` Taylan Ulrich Bayırlı/Kammer
2015-10-18 22:22     ` Artur Malabarba
2015-10-18 22:39       ` Random832
2015-10-19  4:44         ` Eli Zaretskii
2015-10-19  6:00           ` Random832
2015-10-19  6:08             ` Eli Zaretskii
2015-10-19  7:49         ` Artur Malabarba
2015-10-19  8:39       ` Taylan Ulrich Bayırlı/Kammer
2015-10-19  9:30         ` Artur Malabarba
2015-10-19 13:32 ` Wolfgang Jenkner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdUY-LW9CRQRkRziSRtGTMDuRj=Mc3ZUrGhs5TS6QREGxxVWA@mail.gmail.com' \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=taylanbayirli@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.