From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Supporting multiline Package-Requires header Date: Wed, 12 Aug 2015 15:23:05 +0100 Message-ID: References: <87si7rjqmp.fsf@newcastle.ac.uk> <87fv3rjogj.fsf@newcastle.ac.uk> <87fv3po7ss.fsf@russet.org.uk> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1439389403 20430 80.91.229.3 (12 Aug 2015 14:23:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Aug 2015 14:23:23 +0000 (UTC) Cc: Kaushal , Emacs developers , Phillip Lord To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 12 16:23:22 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZPWw3-0006Pn-40 for ged-emacs-devel@m.gmane.org; Wed, 12 Aug 2015 16:23:19 +0200 Original-Received: from localhost ([::1]:38904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPWw2-00015Z-Gw for ged-emacs-devel@m.gmane.org; Wed, 12 Aug 2015 10:23:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPWvx-00015Q-2v for emacs-devel@gnu.org; Wed, 12 Aug 2015 10:23:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPWvr-0002hZ-Cz for emacs-devel@gnu.org; Wed, 12 Aug 2015 10:23:13 -0400 Original-Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:36568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPWvq-0002eO-VM for emacs-devel@gnu.org; Wed, 12 Aug 2015 10:23:07 -0400 Original-Received: by lagz9 with SMTP id z9so9965700lag.3 for ; Wed, 12 Aug 2015 07:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=XiG/soIcXY2fenIeZSs27fkwrRKn+pvKfJU4XGrQeCQ=; b=pU3qS6D93I55n2o7tIBxOdvg7scE/eKaQ0DJrEPJGU33/d1f+ijh2xexmn+wer/ACD MywIGiljtdZ5JWCVSMH8mmfVgsdpPYynhnqNjCs3VdcEBFZcnc/dgpaOTRtvNvQaYHUV /uyroCAZIDHn8/1Tav4GsU7JEARd+eNMutQv5KFUItwZtBcKcwV7vfcP6QtHOkBI+I2r jg6OYGLBG/OH/pHQcoRVXRaZ313ID+1FfqXZ4tVzBWvl0UdSjPq21qsT+J8dAoDmU92j p7FdcSFYAdQSR79EiAkVLzwX0+ptSx3TRl6YEEBElwzaJk2qZNnyF/2Cf6KZ6gihDUA2 W/UQ== X-Received: by 10.112.126.101 with SMTP id mx5mr32567636lbb.35.1439389385463; Wed, 12 Aug 2015 07:23:05 -0700 (PDT) Original-Received: by 10.25.134.139 with HTTP; Wed, 12 Aug 2015 07:23:05 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: 3tYNyJBmBVmrJkmIsRYq63mDVjE X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188758 Archived-At: >> That said, I don't think the proposed patch makes this situation any worse. > > Oh, I missed it. Can you resend it? My brain probably glitched, I meant "the proposed feature". There was no patch yet, but here it is now: --- lisp/emacs-lisp/package.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 9677208..a2027d2 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -982,7 +982,8 @@ boundaries." (narrow-to-region start (point)) (require 'lisp-mnt) ;; Use some headers we've invented to drive the process. - (let* ((requires-str (lm-header "package-requires")) + (let* ((requires-str (when-let ((reqs (lm-header-multiline "package-requires"))) + (apply #'concat reqs))) ;; Prefer Package-Version; if defined, the package author ;; probably wants us to use it. Otherwise try Version. (pkg-version -- 2.4.6