From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5fb807e 1/5: * lisp/files.el: Only message when saving if save-silently is nil Date: Wed, 22 Apr 2015 11:45:34 +0100 Message-ID: References: <20150412151802.21062.89189@vcs.savannah.gnu.org> <55359527.5060108@dancol.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1429699543 32059 80.91.229.3 (22 Apr 2015 10:45:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Apr 2015 10:45:43 +0000 (UTC) To: Daniel Colascione , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 22 12:45:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YksA1-0001X4-9E for ged-emacs-devel@m.gmane.org; Wed, 22 Apr 2015 12:45:41 +0200 Original-Received: from localhost ([::1]:34296 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YksA0-0002dE-8O for ged-emacs-devel@m.gmane.org; Wed, 22 Apr 2015 06:45:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yks9x-0002d7-Qt for emacs-devel@gnu.org; Wed, 22 Apr 2015 06:45:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yks9v-0007fX-Vs for emacs-devel@gnu.org; Wed, 22 Apr 2015 06:45:37 -0400 Original-Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]:34421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yks9v-0007fJ-La for emacs-devel@gnu.org; Wed, 22 Apr 2015 06:45:35 -0400 Original-Received: by lbcga7 with SMTP id ga7so176895821lbc.1 for ; Wed, 22 Apr 2015 03:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=Wvk9eQwU6hgsfHldl+tiJfGNCiYYRMkwhRT/GWw9V54=; b=X8qik4/Tu+yflWQe1v1fZ+D6ZEhxHOTH0edUUCgwo1Oz5jH39EenuYcmiGaTj4e0bX vClYc66ef8AR6ut8dtL7umZREgFKP2p1pfsqYFLZVuVZ8YLhcl9wUr70Ns/iFtSsBW3z Vm8jhJceJIZrl7baze59nkHgMiDGsewulBOHd7+MFu4zOFzBLL6QjEVwhMZHSZg5p7+F +qqXYHoJtMIawge2iMK0f/2IRXC6XvCqioPkcaN6AET0JrJRiYEtmKApR1bYTUK/ovoe kQ9LzrNhZPESVtavZcOtu431FO555ydw/8qMGXTXRac8eG20qQzB4fwoxDebJmlp92U6 7SnQ== X-Received: by 10.152.7.239 with SMTP id m15mr23215321laa.95.1429699534606; Wed, 22 Apr 2015 03:45:34 -0700 (PDT) Original-Received: by 10.25.150.1 with HTTP; Wed, 22 Apr 2015 03:45:34 -0700 (PDT) In-Reply-To: <55359527.5060108@dancol.org> X-Google-Sender-Auth: mvyA_GhcGFQcQnxwGJZIYG8XNWI X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185769 Archived-At: 2015-04-21 1:09 GMT+01:00 Daniel Colascione : >> branch: master >> commit 5fb807efcd6dda113c0cfade9811070e45c36a2f >> >> * lisp/files.el: Only message when saving if save-silently is nil >> >> (save-silently): New variable. >> (files--message): New function. >> >> (find-file-noselect, save-buffer, basic-save-buffer) >> (basic-save-buffer-2, save-some-buffers, not-modified) >> (append-to-file): Use them. > > The (called-interactive-p 'any) in basic-save-buffer always evaluates to > nil --- it's the caller that's called interactively, not this function > --- and so this diff makes C-x C-s silent by default. > The (called-interactively-p 'any) is evaluated in save-buffer not in basic-save-buffer, which is exactly the function that's bound to C-x C-s. So it should not be nil. Do you have an advice on this function, by any chance? I've noticed that advices will cause a command to not be called interactively when it should.