From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Daniel Colascione <dancol@dancol.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 5fb807e 1/5: * lisp/files.el: Only message when saving if save-silently is nil
Date: Wed, 22 Apr 2015 11:45:34 +0100 [thread overview]
Message-ID: <CAAdUY-LLPjhEFwxJ3YY8w_4GpU15PVMeD4BywyCtjG5utcZM1A@mail.gmail.com> (raw)
In-Reply-To: <55359527.5060108@dancol.org>
2015-04-21 1:09 GMT+01:00 Daniel Colascione <dancol@dancol.org>:
>> branch: master
>> commit 5fb807efcd6dda113c0cfade9811070e45c36a2f
>>
>> * lisp/files.el: Only message when saving if save-silently is nil
>>
>> (save-silently): New variable.
>> (files--message): New function.
>>
>> (find-file-noselect, save-buffer, basic-save-buffer)
>> (basic-save-buffer-2, save-some-buffers, not-modified)
>> (append-to-file): Use them.
>
> The (called-interactive-p 'any) in basic-save-buffer always evaluates to
> nil --- it's the caller that's called interactively, not this function
> --- and so this diff makes C-x C-s silent by default.
>
The (called-interactively-p 'any) is evaluated in save-buffer not in
basic-save-buffer, which is exactly the function that's bound to C-x
C-s. So it should not be nil.
Do you have an advice on this function, by any chance? I've noticed
that advices will cause a command to not be called interactively when
it should.
parent reply other threads:[~2015-04-22 10:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <55359527.5060108@dancol.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-LLPjhEFwxJ3YY8w_4GpU15PVMeD4BywyCtjG5utcZM1A@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.