From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 9173a44 1/2: [Fix #12] Don't autodisable beacon on hl-line-mode Date: Sun, 18 Oct 2015 19:48:05 +0100 Message-ID: References: <20151017213254.5317.59042@vcs.savannah.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1445194100 11621 80.91.229.3 (18 Oct 2015 18:48:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Oct 2015 18:48:20 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 18 20:48:15 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Znt07-0003sX-Cx for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 20:48:11 +0200 Original-Received: from localhost ([::1]:35170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Znt06-0008Sf-IX for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 14:48:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Znt03-0008SZ-I1 for emacs-devel@gnu.org; Sun, 18 Oct 2015 14:48:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Znt02-0002oP-Im for emacs-devel@gnu.org; Sun, 18 Oct 2015 14:48:07 -0400 Original-Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:33668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Znt02-0002oJ-Bq for emacs-devel@gnu.org; Sun, 18 Oct 2015 14:48:06 -0400 Original-Received: by lffv3 with SMTP id v3so98112763lff.0 for ; Sun, 18 Oct 2015 11:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=RIqoFeu7xGBquCYXoh3rygBj8y8tvfk9gYvApJH4nOM=; b=KvNU0b97mrwf1StKsWHKH+3JNobD6ZG1OO54Y+q1aB/AIKG/WvFWSx9+Td7LyexCrx AWcmIrA3C+KnXc/OYW2gUI67M+gKpxKKUt62Tc6bOnz0+DM/yR4LB4u6hA2ostBcumHC ED3Uy0eAW7OKFGuHhj7bLxwhB6ntiH9NKpo6IBGj3ww51K2P6PMQ8k0Ow+i7c81cUO9g YYkP+36DLHdDJfuAzL8btquCvyDKnJGdl05yCjbqS0+1v8KR84AZTTwBT66CbS8Z1IIm 7M9rSNOQoiumA2ST9v+5L+UeWwWYeUuN7XqZHZ3Zke8RKobqpwxxCCt46JDj31UYmtT4 sKpQ== X-Received: by 10.25.210.206 with SMTP id j197mr8367929lfg.86.1445194085232; Sun, 18 Oct 2015 11:48:05 -0700 (PDT) Original-Received: by 10.25.22.197 with HTTP; Sun, 18 Oct 2015 11:48:05 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: 0beBiyAlFdXgkMOUFbgYog9VwvY X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191998 Archived-At: Then I'm clearly unaware of something here. There was a discussion here a few months ago where I learned that hooks should always be defined with nil initial values. So, if it must be defined empty, and it's wrong to add entries to it later, then what's the correct way for a package to have a non-empty hook? 2015-10-18 4:20 GMT+01:00 Stefan Monnier : >> + (add-hook 'beacon-dont-blink-predicates >> + (lambda () (bound-and-true-p hl-line-mode)))" >> :type 'hook) > >> -(add-hook 'beacon-dont-blink-predicates (lambda () (bound-and-true-p hl-line-mode))) >> (add-hook 'beacon-dont-blink-predicates #'window-minibuffer-p) > > This add-hook will interfere with defcustom's handling of the variable > (i.e. Customize will rightly complain that "the variable was modified > outside of Customize"). > > > Stefan