From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [elpa] master 9173a44 1/2: [Fix #12] Don't autodisable beacon on hl-line-mode
Date: Sun, 18 Oct 2015 19:48:05 +0100 [thread overview]
Message-ID: <CAAdUY-L9KRD+QBZDB7WD02RGQy5UuJmCQ52KCjUXtEtu_5BPcA@mail.gmail.com> (raw)
In-Reply-To: <jwva8rg3lv1.fsf-monnier+emacsdiffs@gnu.org>
Then I'm clearly unaware of something here.
There was a discussion here a few months ago where I learned that
hooks should always be defined with nil initial values.
So, if it must be defined empty, and it's wrong to add entries to it
later, then what's the correct way for a package to have a non-empty
hook?
2015-10-18 4:20 GMT+01:00 Stefan Monnier <monnier@iro.umontreal.ca>:
>> + (add-hook 'beacon-dont-blink-predicates
>> + (lambda () (bound-and-true-p hl-line-mode)))"
>> :type 'hook)
>
>> -(add-hook 'beacon-dont-blink-predicates (lambda () (bound-and-true-p hl-line-mode)))
>> (add-hook 'beacon-dont-blink-predicates #'window-minibuffer-p)
>
> This add-hook will interfere with defcustom's handling of the variable
> (i.e. Customize will rightly complain that "the variable was modified
> outside of Customize").
>
>
> Stefan
next prev parent reply other threads:[~2015-10-18 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151017213254.5317.59042@vcs.savannah.gnu.org>
[not found] ` <E1ZnZ5y-0001ON-4Z@vcs.savannah.gnu.org>
2015-10-18 3:20 ` [elpa] master 9173a44 1/2: [Fix #12] Don't autodisable beacon on hl-line-mode Stefan Monnier
2015-10-18 18:48 ` Artur Malabarba [this message]
2015-10-19 0:56 ` Stefan Monnier
2015-10-19 5:56 ` Marcin Borkowski
2015-10-19 13:31 ` Stefan Monnier
2015-10-19 14:00 ` Kaushal Modi
2015-10-19 14:20 ` Drew Adams
2015-10-19 14:40 ` Eli Zaretskii
2015-10-19 15:28 ` Kaushal Modi
2015-10-19 16:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-L9KRD+QBZDB7WD02RGQy5UuJmCQ52KCjUXtEtu_5BPcA@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.