From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Helmut Eller <eller.helmut@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Namespace macros
Date: Mon, 8 Dec 2014 11:02:43 +0000 [thread overview]
Message-ID: <CAAdUY-KuhVAuhQ-+b6KJdugNRqPKGbuG6Lg3sYJar0jRLwoj2w@mail.gmail.com> (raw)
In-Reply-To: <m2bnne8pqz.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]
>
> Yes, in most cases dropping the "camcorder-" prefix is a win.
> But this part:
>
> (define-minor-mode mode nil nil "sc"
> '(([f12] . camcorder-stop)
> ([f11] . camcorder-pause))
> ... )
>
> doesn't look so great to me,
Yes. That package is a good example because it portrays how often it works
and how often it doesn't.
I personally find these small issues completely worth the overall beauty of
the code, but that's entirely a matter of preference.
FWIW, Both issues are workaroundable (I'm guessing that's not a word :-)).
> because 1) "define-minor-mode mode" is
> really useless for grep
This will be the case for any namespacing solution. You can work around by
defining the minor mode after the macro.
Also, I would be happy to add an option to avoid namespacing the
`define-minor-mode' form (and similar ones), if anyone wants it.
> 2) it still uses the "camcorder-" prefix for key
> bindings.
This can also be worked around by defining the keymap with a series of
`define-key' statements instead of doing it inside the `define-minor-mode'.
Which is something I see a lot of packages doing anyway.
Now that I think about it, I can also improve the macro to "look inside"
the fifth argument of a `define-minor-mode' call even if it's a quoted
list, since that argument is guaranteed to be a keymap.
[-- Attachment #2: Type: text/html, Size: 1679 bytes --]
next prev parent reply other threads:[~2014-12-08 11:02 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 23:43 Generators (iterators) for Gnu Emacs Michael Heerdegen
2014-12-05 1:55 ` Stefan Monnier
2014-12-05 2:42 ` Leo Liu
2014-12-05 3:23 ` Daniel Colascione
2014-12-05 3:32 ` Leo Liu
2014-12-05 4:19 ` Stefan Monnier
2014-12-05 8:52 ` Leo Liu
2014-12-05 14:40 ` Stefan Monnier
2014-12-05 14:48 ` Stefan Monnier
2014-12-05 15:34 ` Daniel Colascione
2014-12-05 18:32 ` Stefan Monnier
2014-12-05 22:08 ` Daniel Colascione
2014-12-06 9:38 ` Stephen J. Turnbull
2014-12-05 22:08 ` Daniel Colascione
2014-12-05 22:08 ` Daniel Colascione
2014-12-05 22:08 ` Daniel Colascione
2014-12-05 22:08 ` Daniel Colascione
2014-12-05 22:08 ` Daniel Colascione
2014-12-05 22:08 ` Daniel Colascione
2014-12-05 22:08 ` Daniel Colascione
2014-12-05 22:08 ` Daniel Colascione
2014-12-05 9:54 ` David Kastrup
2014-12-05 14:51 ` Stefan Monnier
2014-12-05 17:12 ` Michael Heerdegen
2014-12-05 18:34 ` Stefan Monnier
2014-12-05 19:06 ` Michael Heerdegen
2014-12-06 3:53 ` Stefan Monnier
2014-12-05 18:01 ` Michael Heerdegen
2014-12-05 19:19 ` Stefan Monnier
2014-12-05 22:54 ` Michael Heerdegen
2014-12-05 5:47 ` Thierry Volpiatto
2014-12-05 14:49 ` Stefan Monnier
2014-12-05 17:20 ` Michael Heerdegen
2014-12-05 19:16 ` Stefan Monnier
2014-12-05 22:26 ` Daniel Colascione
2014-12-06 0:13 ` Michael Heerdegen
2014-12-06 0:22 ` Michael Heerdegen
2014-12-06 4:09 ` Stefan Monnier
2014-12-06 9:12 ` Daniel Colascione
2014-12-06 22:24 ` Stefan Monnier
2014-12-07 3:10 ` Daniel Colascione
2014-12-07 6:12 ` Stefan Monnier
2014-12-07 7:51 ` Daniel Colascione
2014-12-07 16:22 ` Ted Zlatanov
2014-12-07 17:40 ` Namespace macros (was: Generators (iterators) for Gnu Emacs) Helmut Eller
2014-12-08 0:11 ` Artur Malabarba
2014-12-08 7:55 ` Namespace macros Helmut Eller
2014-12-08 8:36 ` Artur Malabarba
2014-12-08 9:17 ` Helmut Eller
2014-12-08 11:02 ` Artur Malabarba [this message]
2014-12-08 11:21 ` Dmitry Gutov
2014-12-08 11:42 ` Artur Malabarba
2014-12-08 11:52 ` Dmitry Gutov
2014-12-08 12:52 ` Helmut Eller
2014-12-08 20:59 ` Richard Stallman
2014-12-08 23:37 ` Artur Malabarba
2014-12-09 0:25 ` Helmut Eller
2014-12-07 18:30 ` Generators (iterators) for Gnu Emacs Drew Adams
2014-12-08 0:25 ` Richard Stallman
2014-12-08 1:21 ` Daniel Colascione
2014-12-08 5:34 ` Drew Adams
2014-12-08 20:59 ` Richard Stallman
2014-12-08 21:48 ` Stefan Monnier
2014-12-09 19:35 ` namespaces Ivan Shmakov
2014-12-08 20:59 ` Generators (iterators) for Gnu Emacs Richard Stallman
[not found] ` <<E1Xxm91-0000jQ-Mr@fencepost.gnu.org>
[not found] ` <<5484FD09.60603@dancol.org>
[not found] ` <<9ae6762d-a52a-4a06-b2e9-dab893a22d38@default>
[not found] ` <<E1Xy5Os-0004cU-HF@fencepost.gnu.org>
2014-12-08 21:17 ` Drew Adams
2014-12-07 16:51 ` Stefan Monnier
2014-12-07 17:29 ` Nic Ferrier
2014-12-07 21:17 ` Stefan Monnier
2014-12-07 21:26 ` Nic Ferrier
2014-12-07 21:32 ` Daniel Colascione
2014-12-07 21:43 ` Drew Adams
2014-12-07 23:31 ` Stefan Monnier
2014-12-07 23:39 ` Daniel Colascione
2014-12-08 2:23 ` Stefan Monnier
2014-12-08 2:24 ` Daniel Colascione
2014-12-08 3:23 ` Stefan Monnier
2014-12-08 10:01 ` Thien-Thi Nguyen
2014-12-08 20:35 ` David Engster
2014-12-08 21:45 ` Stefan Monnier
2014-12-08 0:18 ` Dmitry Gutov
2014-12-08 2:25 ` Stefan Monnier
2014-12-08 2:55 ` Dmitry Gutov
2014-12-07 8:54 ` David Kastrup
2014-12-07 9:25 ` Stephen J. Turnbull
[not found] <<877fy77zhp.fsf@web.de>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-KuhVAuhQ-+b6KJdugNRqPKGbuG6Lg3sYJar0jRLwoj2w@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=eller.helmut@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.