Downgrade custom-theme-load-path into a defvar

Downgrade custom-theme-load-path into a defvar

[Artur Malabarba]

`custom-theme-load-path' is a defcustom, but setting it via the
customize interface is a trap for the user. Because installed themes
commonly add themselves to this variable, its value is not fit for
being saved (because it will permanently remember dirs that don't
exist anymore).
This is aggravated by the fact that Emacs always applies the `user'
theme on top of any theme that's loaded, since this will remove apply
the old's variable value and remove any new directories that had been
added by themes themselves.

For an instance of the problem in the wild, see
http://emacs.stackexchange.com/q/2112/50

I'd like to downgrade this defcustom into a defvar, so that users
cannot customize it by accident. It should not be a defcustom in the
same way that load-path isn't.

Would anyone object?


Best,
Artur

Re: Downgrade custom-theme-load-path into a defvar

[John Wiegley]

>>>>> Artur Malabarba <bruce.connor.am@gmail.com> writes:

> I'd like to downgrade this defcustom into a defvar, so that users cannot
> customize it by accident. It should not be a defcustom in the same way that
> load-path isn't.

> Would anyone object?

What about having two load-paths, the way that we have
Info-default-directory-list, and Info-directory-list. The former is intended
to be customized and is not added to, while the second is derived from the
first initially, but possibly added to as Emacs runs.

John

Re: Downgrade custom-theme-load-path into a defvar

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Actually, we have that already.
It's a defcustom called custom-theme-directory. It only holds one
directory, and it is safe to be customised by the user.

On 8 Oct 2015 4:46 am, "John Wiegley" <johnw@newartisans.com> wrote:
>
> >>>>> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
> > I'd like to downgrade this defcustom into a defvar, so that users cannot
> > customize it by accident. It should not be a defcustom in the same way
that
> > load-path isn't.
>
> > Would anyone object?
>
> What about having two load-paths, the way that we have
> Info-default-directory-list, and Info-directory-list. The former is
intended
> to be customized and is not added to, while the second is derived from the
> first initially, but possibly added to as Emacs runs.
>
> John
>

[-- Attachment #2: Type: text/html, Size: 1082 bytes --]

Re: Downgrade custom-theme-load-path into a defvar

[John Wiegley]

>>>>> Artur Malabarba <bruce.connor.am@gmail.com> writes:

> Actually, we have that already. 
> It's a defcustom called custom-theme-directory. It only holds one directory,
> and it is safe to be customised by the user. 

In that case, changing the other defcustom to defvar sounds like the right
change.

John

Re: Downgrade custom-theme-load-path into a defvar

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

We had one more question like that today:
http://emacs.stackexchange.com/q/17256/115


--
Kaushal Modi

On Thu, Oct 8, 2015 at 12:21 PM, John Wiegley <johnw@newartisans.com> wrote:

> >>>>> Artur Malabarba <bruce.connor.am@gmail.com> writes:
>
> > Actually, we have that already.
> > It's a defcustom called custom-theme-directory. It only holds one
> directory,
> > and it is safe to be customised by the user.
>
> In that case, changing the other defcustom to defvar sounds like the right
> change.
>
> John
>
>

[-- Attachment #2: Type: text/html, Size: 1287 bytes --]