From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Downgrade custom-theme-load-path into a defvar Date: Wed, 7 Oct 2015 19:23:20 +0100 Message-ID: Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1444242220 11818 80.91.229.3 (7 Oct 2015 18:23:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Oct 2015 18:23:40 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 07 20:23:39 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZjtNJ-0004dN-Ro for ged-emacs-devel@m.gmane.org; Wed, 07 Oct 2015 20:23:37 +0200 Original-Received: from localhost ([::1]:58978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjtNJ-0003VZ-0I for ged-emacs-devel@m.gmane.org; Wed, 07 Oct 2015 14:23:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjtN7-0003VO-7y for emacs-devel@gnu.org; Wed, 07 Oct 2015 14:23:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjtN3-0007qQ-Cf for emacs-devel@gnu.org; Wed, 07 Oct 2015 14:23:25 -0400 Original-Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:35238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjtN3-0007pv-59 for emacs-devel@gnu.org; Wed, 07 Oct 2015 14:23:21 -0400 Original-Received: by lbwr8 with SMTP id r8so20961226lbw.2 for ; Wed, 07 Oct 2015 11:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:date:message-id:subject:from:to :content-type; bh=UOzQCzW9FKkUHq6rg284wQWOvNVE4iUoJBvWs3jZv5c=; b=ka84BecB+p9TZAUrsfq57+MpnWUqGGQdGS+lRnyiMzXO2k5WHXM3AiTmG1BnFHiAL2 uU2xbCEpIFAuXHwrFriRmlKHCfhR2Um9f5oyNLp2WCwornGibnXUnrYtl9fvEGDnAObh yNVx1xALJRll3tXz9V8z0Fwu6hkf0MSITzIxlZ0xW23gWSUfwDdt3HumhXZ4qhPlYQ/4 ms4iMcM/7MKmJ88AgWgb10Y0q+ftRR9bH6xkwNHLYtNFUWSBnIfxlhD/9hKnjVuyi4/F OLIMU6w42sjzEl7HFiLNy29u4hB2ERTfVVHZalZirAwTM0CO7CZrnUEUmu5j5nHHwS0T YD6w== X-Received: by 10.25.165.4 with SMTP id o4mr953999lfe.4.1444242200094; Wed, 07 Oct 2015 11:23:20 -0700 (PDT) Original-Received: by 10.25.27.78 with HTTP; Wed, 7 Oct 2015 11:23:20 -0700 (PDT) X-Google-Sender-Auth: n4pMFnPk6x5VRH7GA-0Elnh0G5o X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:191056 Archived-At: `custom-theme-load-path' is a defcustom, but setting it via the customize interface is a trap for the user. Because installed themes commonly add themselves to this variable, its value is not fit for being saved (because it will permanently remember dirs that don't exist anymore). This is aggravated by the fact that Emacs always applies the `user' theme on top of any theme that's loaded, since this will remove apply the old's variable value and remove any new directories that had been added by themes themselves. For an instance of the problem in the wild, see http://emacs.stackexchange.com/q/2112/50 I'd like to downgrade this defcustom into a defvar, so that users cannot customize it by accident. It should not be a defcustom in the same way that load-path isn't. Would anyone object? Best, Artur