all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Downgrade custom-theme-load-path into a defvar
Date: Wed, 7 Oct 2015 19:23:20 +0100	[thread overview]
Message-ID: <CAAdUY-KtyEZqvm=bgN8x6hg+YZyU20RvprxOuT0BMwpto8SeGA@mail.gmail.com> (raw)

`custom-theme-load-path' is a defcustom, but setting it via the
customize interface is a trap for the user. Because installed themes
commonly add themselves to this variable, its value is not fit for
being saved (because it will permanently remember dirs that don't
exist anymore).
This is aggravated by the fact that Emacs always applies the `user'
theme on top of any theme that's loaded, since this will remove apply
the old's variable value and remove any new directories that had been
added by themes themselves.

For an instance of the problem in the wild, see
http://emacs.stackexchange.com/q/2112/50

I'd like to downgrade this defcustom into a defvar, so that users
cannot customize it by accident. It should not be a defcustom in the
same way that load-path isn't.

Would anyone object?


Best,
Artur



             reply	other threads:[~2015-10-07 18:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 18:23 Artur Malabarba [this message]
2015-10-08  3:46 ` Downgrade custom-theme-load-path into a defvar John Wiegley
2015-10-08  6:29   ` Artur Malabarba
2015-10-08 16:21     ` John Wiegley
2015-10-09 17:46       ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdUY-KtyEZqvm=bgN8x6hg+YZyU20RvprxOuT0BMwpto8SeGA@mail.gmail.com' \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.