From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: package-install-from-buffer moves point
Date: Sun, 19 Jul 2015 18:06:26 +0100 [thread overview]
Message-ID: <CAAdUY-KmjFmyeE1SO+XAt5mzCMed9=fFc2WuNVqfyPKsTjHYhA@mail.gmail.com> (raw)
In-Reply-To: <55ABCC84.4000400@eisentraut.org>
>> This is due to calls to some `lm-*' functions inside
>> `package-buffer-info' (possibly one of the calls I added myself
>> yesterday). I can just wrap those in save-excursions, but I'm thinking
>> that the `lm-*' functions themselves should not be moving the point.
>> Shall I use save-excursion inside those functions instead?
>
> Well, there is also a goto-char call right at the top of
> package-buffer-info.
Clearly I should stop replying to messages on my phone where I can't
look at the code first. :)
> But I agree that the lm-* functions should
> probably save the point themselves, too. There are some calls to
> save-excursion in lisp-mnt.el, but it seems it's not applied consistently.
Yes. `lm-header' always moves point to the header (besides returning
it). All the others I looked through seem to be fine.
next prev parent reply other threads:[~2015-07-19 17:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 13:54 package-install-from-buffer moves point Peter Eisentraut
2015-07-18 15:13 ` Artur Malabarba
2015-07-19 16:12 ` Peter Eisentraut
2015-07-19 17:06 ` Artur Malabarba [this message]
2015-11-07 18:03 ` Peter Eisentraut
2015-11-07 22:51 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdUY-KmjFmyeE1SO+XAt5mzCMed9=fFc2WuNVqfyPKsTjHYhA@mail.gmail.com' \
--to=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=peter@eisentraut.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.