From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>,
Jonas Bernoulli <jonas@bernoul.li>,
22616@debbugs.gnu.org
Subject: bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline
Date: Mon, 09 May 2016 02:13:24 +0000 [thread overview]
Message-ID: <CAAdUY-KcRyuFj-ocbAMpwnWBXhqfZ9ayPvYojORHOMY8MzBmcg@mail.gmail.com> (raw)
In-Reply-To: <40c67906-d293-4af8-e3be-652fb6bf67d1@yandex.ru>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
IIRC, I made this change because the previous behaviour caused
`package-install-from-buffer' to move point. Since I saw no reason for
lm-header to move point, I fixed the issue at its roots.
Clearly, we've found a reason now. So the save excursion should be removed
from the latter function to the former.
On Sun, 8 May 2016 8:52 pm Dmitry Gutov, <dgutov@yandex.ru> wrote:
> Arthur,
>
> could you look into this one? And at the bug#22510 merged with it.
>
> Do you remember why you made this change?
>
> On 02/10/2016 06:17 PM, Jonas Bernoulli wrote:
> > Starting with bf3f6a961f378f35a292c41c0bfbdae88ee1b1b9 `lm-header's body
> > is wrapped with `save-excursion', but `lm-header-multiline' only works
> > properly if `lm-header' doesn't do that.
> >
> > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.25)
> > of 2016-01-28 built on hal
> > Repository revision: 9be8a2fb41043b4d4734a67f155d6923df10671b
>
[-- Attachment #2: Type: text/html, Size: 1266 bytes --]
next prev parent reply other threads:[~2016-05-09 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 16:17 bug#22616: 25.0.50; Change to lm-header breaks lm-header-multiline Jonas Bernoulli
2016-05-08 23:52 ` Dmitry Gutov
2016-05-09 2:13 ` Artur Malabarba [this message]
2016-05-11 0:00 ` Dmitry Gutov
2016-05-11 22:34 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-KcRyuFj-ocbAMpwnWBXhqfZ9ayPvYojORHOMY8MzBmcg@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=22616@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.