From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Suspicious code in align.el Date: Sun, 3 Jan 2016 15:54:57 +0000 Message-ID: References: Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1451836505 27535 80.91.229.3 (3 Jan 2016 15:55:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Jan 2016 15:55:05 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 03 16:55:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aFkzn-0005qn-Uj for ged-emacs-devel@m.gmane.org; Sun, 03 Jan 2016 16:55:04 +0100 Original-Received: from localhost ([::1]:42073 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFkzm-00056Q-4r for ged-emacs-devel@m.gmane.org; Sun, 03 Jan 2016 10:55:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFkzj-00056E-2I for emacs-devel@gnu.org; Sun, 03 Jan 2016 10:54:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aFkzi-0008FH-BU for emacs-devel@gnu.org; Sun, 03 Jan 2016 10:54:59 -0500 Original-Received: from mail-yk0-x233.google.com ([2607:f8b0:4002:c07::233]:33328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aFkzi-0008FC-6f for emacs-devel@gnu.org; Sun, 03 Jan 2016 10:54:58 -0500 Original-Received: by mail-yk0-x233.google.com with SMTP id k129so205437336yke.0 for ; Sun, 03 Jan 2016 07:54:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=h4SaOOxhVjRzMp8w2YiigQP+slJjfRNJ6XRJ4Fv3OB8=; b=DN5ebfOsEWvII9A8bFoN+bMtMA4wTfvjEHcRocbVSuXTRP7QwozcOQxPK3ns6uXVMW SreX/3k+dkb82GwwdcD91JNzHunDwyjKwUGbJmAPLBvrRLYHD/xF04gSQuoi5jlG8lkU GCfgDyKWj+Au/QcSISnT1mq09kVFLSK4OHfIFBlkomm1q0yuDv4y85NbJz6wIcqfjd2S 6OuKr4TYnyTTtxo3Swffwx54KOSriGZ7ixRcWMjMqtwQ3AWrcr9fmDw7ThndkAmoebpS f9/9ftyEhYk55fn4CjpZLUuSF5bwWC1hBUddA6pMKvTh9mPAsvXvuGO8zIkLfXwnarWy iPMQ== X-Received: by 10.129.102.133 with SMTP id a127mr59677032ywc.283.1451836497614; Sun, 03 Jan 2016 07:54:57 -0800 (PST) Original-Received: by 10.129.87.130 with HTTP; Sun, 3 Jan 2016 07:54:57 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: fvNIrDcpGC3O8qdeghCUFh7em-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4002:c07::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197455 Archived-At: 2016-01-02 22:18 GMT+00:00 John Wiegley : >>>>>> Artur Malabarba writes: > >> In line 890 of this file, there's a call to align-regexp that looks like >> this... > > Nice catch, Artur, the code at least is wrong. The 3rd argument should be > shifted forward to become the 5th argument. > > I wonder what fixing this will break... :) Since it's possible this will break something else, should this "fix" go on master instead of the release branch?