From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.diffs,gmane.emacs.devel Subject: Re: master 6aa04a5: * lisp/json.el (json-end-of-file): New error. Date: Fri, 6 Feb 2015 01:05:49 +0000 Message-ID: References: <20150205195209.31856.78267@vcs.savannah.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1423184759 32236 80.91.229.3 (6 Feb 2015 01:05:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Feb 2015 01:05:59 +0000 (UTC) Cc: emacs-diffs@gnu.org To: emacs-devel , Era Eriksson , Stefan Monnier Original-X-From: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Fri Feb 06 02:05:58 2015 Return-path: Envelope-to: gnu-emacs-diffs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJXMp-0006Jf-EN for gnu-emacs-diffs@m.gmane.org; Fri, 06 Feb 2015 02:05:55 +0100 Original-Received: from localhost ([::1]:46211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJXMo-0002nr-J6 for gnu-emacs-diffs@m.gmane.org; Thu, 05 Feb 2015 20:05:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJXMl-0002nF-Er for emacs-diffs@gnu.org; Thu, 05 Feb 2015 20:05:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJXMk-0001qV-DG for emacs-diffs@gnu.org; Thu, 05 Feb 2015 20:05:51 -0500 Original-Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]:55006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJXMk-0001qG-8L; Thu, 05 Feb 2015 20:05:50 -0500 Original-Received: by mail-oi0-f42.google.com with SMTP id i138so9473117oig.1; Thu, 05 Feb 2015 17:05:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=7d5I6CMjMMY4+ooIXruvvX8M+8kpv89nX9LPPRH1KqE=; b=BnkQKXGWPsAjJgTUVuBhSMkKgvA56DAdcS146KW6WOGdQ47PRzRYoY/YL8/kA3mbZt 6cep0+4quXGFSlygqjEpxemgaQS1xlddHG6wUZS9ZRdwcHoO5+SUX0KwDfaw4DXUyEXv a0B8pjeEz2yelvzpeGwkpWDWXzKhmzw5vAFImPoC07QrGSGAeamAMWmH47/vw3zZW37s 5zjYVfqbWWW6CuA+sZKaMfNcZRGlixxcMJ5m0mJzaJDtD4PI8TiRDkBqKxg5bHvvAwx8 wXo7+Bn03dcXivQzT4xgDUxq4g5P4AoxKQIOwkyUJoRHflJ016ig9sgveB5V/qPLYJm8 6qkQ== X-Received: by 10.182.97.105 with SMTP id dz9mr724982obb.46.1423184749822; Thu, 05 Feb 2015 17:05:49 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Thu, 5 Feb 2015 17:05:49 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: sL-TNIq1Fvtg1fFkavSJo59C0rQ X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::22a X-BeenThere: emacs-diffs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for Emacs changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Original-Sender: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.diffs:128957 gmane.emacs.devel:182486 Archived-At: > +(define-error 'json-end-of-file "End of file while parsing JSON" > + '(end-of-file json-error)) When this form is evaluated, I get the following error: error: "Attempt to modify read-only object", (error) Looking into `define-error', this happens when it tries to `apply' `nconc' on the result of the `mapcar', which is this: ((end-of-file end-of-file error) (json-error json-error error)) I think it may be a bug in `define-error', where that nconc should be an append. Otherwise, nconc tries to destructively change the list it gets from (get parent 'error-conditions), which I'm guessing shouldn't be changed. I may just be wrong, though. `git blame' reveal this function has existed in this form since 2013...