all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>,
	Era Eriksson <era+emacs@iki.fi>,
	 Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-diffs@gnu.org
Subject: Re: master 6aa04a5: * lisp/json.el (json-end-of-file): New error.
Date: Fri, 6 Feb 2015 01:05:49 +0000	[thread overview]
Message-ID: <CAAdUY-KXFO9VzLUYzGgEdL=Y7+DEdSC2xHc5Mqw2JxURdqMQ5w@mail.gmail.com> (raw)
In-Reply-To: <E1YJSTB-0008IQ-ER@vcs.savannah.gnu.org>

> +(define-error 'json-end-of-file "End of file while parsing JSON"
> +  '(end-of-file json-error))

When this form is evaluated, I get the following error:
     error: "Attempt to modify read-only object", (error)

Looking into `define-error', this happens when it tries to `apply'
`nconc' on the result of the `mapcar', which is this:
    ((end-of-file end-of-file error) (json-error json-error error))


I think it may be a bug in `define-error', where that nconc should be
an append. Otherwise, nconc tries to destructively change the list it
gets from (get parent 'error-conditions), which I'm guessing shouldn't
be changed.
I may just be wrong, though. `git blame' reveal this function has
existed in this form since 2013...


           reply	other threads:[~2015-02-06  1:05 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <E1YJSTB-0008IQ-ER@vcs.savannah.gnu.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdUY-KXFO9VzLUYzGgEdL=Y7+DEdSC2xHc5Mqw2JxURdqMQ5w@mail.gmail.com' \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-diffs@gnu.org \
    --cc=era+emacs@iki.fi \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.