From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/package-fix e5d5cdf 1/2: emacs-lisp/package.el: Indicate incompatible packages. Date: Wed, 11 Feb 2015 23:00:24 +0000 Message-ID: References: <20150211170820.10979.16862@vcs.savannah.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113d5edcfe4aa4050ed7f794 X-Trace: ger.gmane.org 1423695773 30952 80.91.229.3 (11 Feb 2015 23:02:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Feb 2015 23:02:53 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 12 00:02:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YLgIx-0007SY-JG for ged-emacs-devel@m.gmane.org; Thu, 12 Feb 2015 00:02:47 +0100 Original-Received: from localhost ([::1]:47333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLgIw-0003Hc-Hg for ged-emacs-devel@m.gmane.org; Wed, 11 Feb 2015 18:02:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLgIj-0003HL-Q4 for emacs-devel@gnu.org; Wed, 11 Feb 2015 18:02:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLgIj-0004Bq-19 for emacs-devel@gnu.org; Wed, 11 Feb 2015 18:02:33 -0500 Original-Received: from mail-oi0-x230.google.com ([2607:f8b0:4003:c06::230]:40766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLgGf-0003UC-Lm for emacs-devel@gnu.org; Wed, 11 Feb 2015 18:00:25 -0500 Original-Received: by mail-oi0-f48.google.com with SMTP id a3so172347oib.7 for ; Wed, 11 Feb 2015 15:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=yzus8AH+JJQ+uH7BEdyozAl1Rg87vVXXaUTauG4BWYU=; b=QTe4+k4k15IBo6uxlrwVMcrIjRgdlEpaZcvEPPqbqH5vJ/Sp1anqb/pg/keLlrNHn2 2DNSilR7+YLU+w+o3GAbLjK7TBDARXnDuM3uk8akjwMp1+dtXBd4FZKp3q3DP3CMIdL4 yW8QuniB8s4v08wCPGXpMQzy5lAKG5gBFKhOlUE+C5VUNF5P7rIpCbg//DDBPdEAP6gN sNEBtCg27sBHH6Lqly3kV4wjxUP6L2/7V80KLHVq7SUIHvW6tw4bf+1FwV0wpH3Qq61i iGIenefpkoFhVnZ44gfmA2809xOST203Gi3i2BnoUY5L9ATgPGp70qfTJEDeq3fvFASN TATA== X-Received: by 10.202.90.3 with SMTP id o3mr537080oib.99.1423695624946; Wed, 11 Feb 2015 15:00:24 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Wed, 11 Feb 2015 15:00:24 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Wed, 11 Feb 2015 15:00:24 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: tVWEtcDPfiSMN4Et76JaJqsTMiE X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182920 Archived-At: --001a113d5edcfe4aa4050ed7f794 Content-Type: text/plain; charset=UTF-8 > > + ((not (package--compatible-p pkg-desc)) "incompat") > > Of course, this should be transitive: if one of the required packages is > "incompat", then the package is also "incompat". Ideally, yes. That's why I factored it out as a function. However, this is called on each package about to be printed, and checking whether the dependencies are available imposes a performance cost that I'm not sure we should pay. The time for printing the package list will go from linear to quadratic in the number of packages. --001a113d5edcfe4aa4050ed7f794 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

> > +=C2=A0 =C2=A0 =C2=A0((not (package--compatible-p = pkg-desc)) "incompat")
>
> Of course, this should be transitive: if one of the required packages = is
> "incompat", then the package is also "incompat".

Ideally, yes. That's why I factored it out as a function= .

However, this is called on each package about to be printed,= and checking whether the dependencies are available imposes a performance = cost that I'm not sure we should pay. The time for printing the package= list will go from linear to quadratic in the number of packages.

--001a113d5edcfe4aa4050ed7f794--