From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it? Date: Fri, 30 Jan 2015 23:57:25 +0000 Message-ID: References: <87iofo7xfo.fsf@ahungry.com> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c21ca8c6ae9f050de75d3d X-Trace: ger.gmane.org 1422662264 17673 80.91.229.3 (30 Jan 2015 23:57:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 Jan 2015 23:57:44 +0000 (UTC) Cc: emacs-devel To: M Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 31 00:57:43 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YHLRU-0007Wq-Iv for ged-emacs-devel@m.gmane.org; Sat, 31 Jan 2015 00:57:40 +0100 Original-Received: from localhost ([::1]:39171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHLRU-0006ob-2t for ged-emacs-devel@m.gmane.org; Fri, 30 Jan 2015 18:57:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHLRG-0006oW-Qg for emacs-devel@gnu.org; Fri, 30 Jan 2015 18:57:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHLRG-0005nk-3I for emacs-devel@gnu.org; Fri, 30 Jan 2015 18:57:26 -0500 Original-Received: from mail-ob0-x233.google.com ([2607:f8b0:4003:c01::233]:43959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHLRF-0005nD-Vi for emacs-devel@gnu.org; Fri, 30 Jan 2015 18:57:26 -0500 Original-Received: by mail-ob0-f179.google.com with SMTP id va8so15876768obc.10 for ; Fri, 30 Jan 2015 15:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=S4j3RFxlgDDuYOZxXwnxm9pSYVMVyEYyAq5b9oCy0FU=; b=Z1GpXPZ01UNgU0wEz4B7BBX3emt5TkgNj+OyDaiI2igb7LIMHTpn6dWaLJIgNyHMum BniCiRZ0CYdyvv7ckmaA82s73qRaanwhq/ArtfefGYIO8c+USKbPF54BAGBR3UfGYnuw g6igLmKeFv07oJwkGa9arC998gCbJlELV4rPtiinPMPKqVg3AGftkpLfJ5xv0qgyaE8Y d9S0hXRO6stZQUAF5N9ahEpdCbolcJkknKSq9F1bJGNJ6P/iFu67c25v+5EWZA1SR6WQ PX1URRFxzaylOPHacu5ZRUneG1bc5PX34DWYkkKaCQKw8kisWWaGzp8MQ263rt9e+5+U M75w== X-Received: by 10.60.62.241 with SMTP id b17mr5292798oes.17.1422662245459; Fri, 30 Jan 2015 15:57:25 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Fri, 30 Jan 2015 15:57:25 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Fri, 30 Jan 2015 15:57:25 -0800 (PST) In-Reply-To: <87iofo7xfo.fsf@ahungry.com> X-Google-Sender-Auth: CXPT0SyfXxKTwVbS8C9OYnFJwiA X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182104 Archived-At: --001a11c21ca8c6ae9f050de75d3d Content-Type: text/plain; charset=UTF-8 > 1) Add itself to the user's custom-theme-load-path Yes. The code is a little tricky, so look into how other themes do it. > 2) Load itself via load-theme Absolutely not. Users should be able to have multiple themes installed without them all turning on simultaneously. I do agree with need a more intuitive theming experience for new users, but that's a whole other topic. --001a11c21ca8c6ae9f050de75d3d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

> =C2=A0 1) Add itself to the user's custom-theme-loa= d-path

Yes. The code is a little tricky, so look into how other the= mes do it.

> =C2=A0 2) Load itself via load-theme

Absolutely not. Users should be able to have multiple themes= installed without them all turning on simultaneously.

I do agree with need a more intuitive theming experience for= new users, but that's a whole other topic.

--001a11c21ca8c6ae9f050de75d3d--