From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.bugs Subject: bug#20810: 25.0.50; tabulated-list is broken Date: Sun, 14 Jun 2015 14:38:12 +0100 Message-ID: References: <87lhfmqz01.fsf@gmx.de> <87fv5uqwie.fsf@gmx.de> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1434289161 24218 80.91.229.3 (14 Jun 2015 13:39:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Jun 2015 13:39:21 +0000 (UTC) Cc: 20810@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 14 15:39:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z487z-0001ua-DH for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jun 2015 15:39:11 +0200 Original-Received: from localhost ([::1]:58718 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z487y-0006GF-CL for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Jun 2015 09:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z487u-0006G7-GB for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2015 09:39:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z487r-0001Yh-4p for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2015 09:39:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z487r-0001YR-0y for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2015 09:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z487q-0002SG-HN for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2015 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Artur Malabarba Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jun 2015 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20810-submit@debbugs.gnu.org id=B20810.14342891029389 (code B ref 20810); Sun, 14 Jun 2015 13:39:02 +0000 Original-Received: (at 20810) by debbugs.gnu.org; 14 Jun 2015 13:38:22 +0000 Original-Received: from localhost ([127.0.0.1]:53325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z487B-0002RM-Un for submit@debbugs.gnu.org; Sun, 14 Jun 2015 09:38:22 -0400 Original-Received: from mail-lb0-f171.google.com ([209.85.217.171]:33790) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z4878-0002R5-Gr for 20810@debbugs.gnu.org; Sun, 14 Jun 2015 09:38:19 -0400 Original-Received: by lblr1 with SMTP id r1so13215427lbl.0 for <20810@debbugs.gnu.org>; Sun, 14 Jun 2015 06:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=upqT+2N2Mn7LJ/P3fRXBIH1uydthCFAZI+JiUNCbjHQ=; b=gTXo4ehEWm60gMS0+Q2Qj3BMwyP4He5DP0klWHvjZq7Ka0+xc216Mw9w4om7UfkwEo 7kWakQqbIusZ880eIgylwnA9PH+YuzaZP9kLzI1NlmcmB8MnE6OmJqjLETVwXuRHXwqh h90/025+40ExghlWxwy4LfBmsVcIYVK3QmxN1rpCYXxVYZWuNIHSIU3CYdQWu1W362Fb OnghaBa1BxmLoP5FrXiVhxRuNErOlUCEEOH0GSkxCztc8gXrb7lY7FpNxyrz0twVIfke E3wKQi4lk+8L2dyh13UhDp/+MhwKCs7lqD+08ieWmWr2UOchX3MhAEnYC63OUOQpxfJ/ wKDw== X-Received: by 10.112.210.137 with SMTP id mu9mr22289915lbc.95.1434289092621; Sun, 14 Jun 2015 06:38:12 -0700 (PDT) Original-Received: by 10.25.214.133 with HTTP; Sun, 14 Jun 2015 06:38:12 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: hUFOjS4HyxHsVqkAIWg1nEIeEmk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103932 Archived-At: Ok I've spotted the problem. The logic I implemented assumed that the `tabulated-list-printer' function (which is used to print each entry) would always leave point after the printed content, which is not what debbugs does. Debbugs uses this to also print some content at the top and bottom of the buffer the first time it is called I'll find a better way to write this. 2015-06-14 14:29 GMT+01:00 Artur Malabarba : >>> I can't reproduce that. Could you try emacs -Q? >> >> Hmm, I did a "git pull" and recompiled everything, and the problem is >> gone for me with the `buffer-menu' command. But it still remains for >> `debbugs-gnu'. > > Ok, I confirm I have it for debbugs as well. > >> The second argument s2 of `debbugs-gnu-sort-id' is (nil nil), which >> doesn't look like a valid sort item. > > Indeed. > >> Does `tabulated-list-print' calls the >> sort function with possibly incorrect items? Or is there an incompatible >> change? > > Answer to both of these should be "no", but clearly at least one > isn't. :-) I'm looking into it. > >> etc/NEWS mentions a change of `tabulated-list-print', but I don't >> see how it is related to the problem. > > As part of that change, the sorting logic got refactored a bit, so I > probably messed it up. It doesn't really have anything to do with the > new printing method that's actually announced in the news.