From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 20810@debbugs.gnu.org
Subject: bug#20810: 25.0.50; tabulated-list is broken
Date: Sun, 14 Jun 2015 14:38:12 +0100 [thread overview]
Message-ID: <CAAdUY-KUN2DtuA3gfAPEJNfESBP3jVF6kMLGoQHei9p3J0DsLA@mail.gmail.com> (raw)
In-Reply-To: <CAAdUY-LE20TEy-yaSsReNFQkJYYq6SJxp=oXphE7MQOnXgnStA@mail.gmail.com>
Ok I've spotted the problem. The logic I implemented assumed that the
`tabulated-list-printer' function (which is used to print each entry)
would always leave point after the printed content, which is not what
debbugs does. Debbugs uses this to also print some content at the top
and bottom of the buffer the first time it is called
I'll find a better way to write this.
2015-06-14 14:29 GMT+01:00 Artur Malabarba <bruce.connor.am@gmail.com>:
>>> I can't reproduce that. Could you try emacs -Q?
>>
>> Hmm, I did a "git pull" and recompiled everything, and the problem is
>> gone for me with the `buffer-menu' command. But it still remains for
>> `debbugs-gnu'.
>
> Ok, I confirm I have it for debbugs as well.
>
>> The second argument s2 of `debbugs-gnu-sort-id' is (nil nil), which
>> doesn't look like a valid sort item.
>
> Indeed.
>
>> Does `tabulated-list-print' calls the
>> sort function with possibly incorrect items? Or is there an incompatible
>> change?
>
> Answer to both of these should be "no", but clearly at least one
> isn't. :-) I'm looking into it.
>
>> etc/NEWS mentions a change of `tabulated-list-print', but I don't
>> see how it is related to the problem.
>
> As part of that change, the sorting logic got refactored a bit, so I
> probably messed it up. It doesn't really have anything to do with the
> new printing method that's actually announced in the news.
next prev parent reply other threads:[~2015-06-14 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 12:01 bug#20810: 25.0.50; tabulated-list is broken Michael Albinus
2015-06-14 12:35 ` Artur Malabarba
2015-06-14 12:56 ` Michael Albinus
2015-06-14 13:29 ` Artur Malabarba
2015-06-14 13:38 ` Artur Malabarba [this message]
2015-06-14 13:43 ` Artur Malabarba
2015-06-14 14:02 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-KUN2DtuA3gfAPEJNfESBP3jVF6kMLGoQHei9p3J0DsLA@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=20810@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.