From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Short patch for review Date: Thu, 19 Feb 2015 11:07:04 +0000 Message-ID: References: <83r3tm4fia.fsf@gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c341aca444f1050f6eefca X-Trace: ger.gmane.org 1424344040 19471 80.91.229.3 (19 Feb 2015 11:07:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Feb 2015 11:07:20 +0000 (UTC) Cc: Kelly Dean , emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 19 12:07:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOOwv-00086I-Ct for ged-emacs-devel@m.gmane.org; Thu, 19 Feb 2015 12:07:17 +0100 Original-Received: from localhost ([::1]:55734 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOOwu-0007QB-JU for ged-emacs-devel@m.gmane.org; Thu, 19 Feb 2015 06:07:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOOwr-0007Q4-26 for emacs-devel@gnu.org; Thu, 19 Feb 2015 06:07:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOOwq-0007ZZ-2A for emacs-devel@gnu.org; Thu, 19 Feb 2015 06:07:12 -0500 Original-Received: from mail-lb0-f182.google.com ([209.85.217.182]:41053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOOwj-0007X7-I3; Thu, 19 Feb 2015 06:07:05 -0500 Original-Received: by lbiz11 with SMTP id z11so6697750lbi.8; Thu, 19 Feb 2015 03:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=p+AmNkMqrrBo1s0SF3ykRFomNrgeRcyC/gwZnecWBqM=; b=DgK4UfajOhHS5Fy0xboo2BBYTiYgHmXWZy34Nb2QciofMTJDkryE3GufFu1bGu42QL 5zvyZrdOHYYvNFopG2CYFgw8QZsLxkE4wnLFaPDriCzTWbw9tHfJBTCJVZZKWwD5gvCC GV1VhQvBfryIDMD3gmGJTj91bA+hMJ/yh651dkqZvlCaAea7uMzE0p+sScJQp0/JPkpy Muk/fV9usmPZ3HMd5K+bX1kH2IiQTTrte8vMjYZ2mirnni17RhMHFbDLGUygwMOjoy57 kYJWsZmYqPCbY4lV7nVJXSGhx4mfUbNufohBlaYsVW5Mi3fJOGnCQ+/DN1TIw/JvAgPM K25g== X-Received: by 10.112.198.1 with SMTP id iy1mr3466668lbc.13.1424344024890; Thu, 19 Feb 2015 03:07:04 -0800 (PST) Original-Received: by 10.112.64.106 with HTTP; Thu, 19 Feb 2015 03:07:04 -0800 (PST) Original-Received: by 10.112.64.106 with HTTP; Thu, 19 Feb 2015 03:07:04 -0800 (PST) In-Reply-To: <83r3tm4fia.fsf@gnu.org> X-Google-Sender-Auth: uU3Ae5LAo0ZCkGX2BMWoJ3CLmrM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183292 Archived-At: --001a11c341aca444f1050f6eefca Content-Type: text/plain; charset=UTF-8 According to its docstring, it's for cases where the user does something wrong. Calling a command on the wrong buffer, providing invalid input, things like that. We also have a few instances where it's used to abort commands when the user answers "No" to a query. I'm not 100% sure those instances qualify, but it's certainly way better than throwing actual errors. On Feb 19, 2015 5:49 AM, "Eli Zaretskii" wrote: > > Date: Wed, 18 Feb 2015 19:17:52 -0200 > > From: Artur Malabarba > > Cc: Kelly Dean > > > > Hi all, Kelly sent me a patch for changing a couple of `error' > > instances into `user-error'. > > It looks ok to me, but I'd appreciate if someone could confirm that > > it's alright. > > Do we have guidelines for which errors should be 'user-error'? > --001a11c341aca444f1050f6eefca Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

According to its docstring, it's for cases where the use= r does something wrong. Calling a command on the wrong buffer, providing in= valid input, things like that.

We also have a few instances where it's used to abort co= mmands when the user answers "No" to a query. I'm not 100% su= re those instances qualify, but it's certainly way better than throwing= actual errors.

On Feb 19, 2015 5:49 AM, "Eli Zaretskii&quo= t; <eliz@gnu.org> wrote:
> Date: Wed, 18 Feb 2015= 19:17:52 -0200
> From: Artur Malabarba <bruce.connor.am@gmail.com>
> Cc: Kelly Dean <kelly@prtime.or= g>
>
> Hi all, Kelly sent me a patch for changing a couple of `error'
> instances into `user-error'.
> It looks ok to me, but I'd appreciate if someone could confirm tha= t
> it's alright.

Do we have guidelines for which errors should be 'user-error'?
--001a11c341aca444f1050f6eefca--