From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Questions about isearch Date: Sat, 28 Nov 2015 20:00:24 +0000 Message-ID: References: <83lh9lx6oi.fsf@gnu.org> <83a8q1x1cn.fsf@gnu.org> <87h9k74pkw.fsf@gmail.com> <83bnafse4f.fsf@gnu.org> <878u5jrvih.fsf@rub.de> <87mvtyqzyx.fsf@mbork.pl> <831tbaqwwv.fsf@gnu.org> <83k2p2p4ob.fsf@gnu.org> <83a8pyow7z.fsf@gnu.org> <83610mosu2.fsf@gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1448740832 12196 80.91.229.3 (28 Nov 2015 20:00:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Nov 2015 20:00:32 +0000 (UTC) Cc: emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 28 21:00:29 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2lfY-0003nZ-ER for ged-emacs-devel@m.gmane.org; Sat, 28 Nov 2015 21:00:28 +0100 Original-Received: from localhost ([::1]:33598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2lfb-0002UP-UO for ged-emacs-devel@m.gmane.org; Sat, 28 Nov 2015 15:00:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2lfY-0002U9-DQ for emacs-devel@gnu.org; Sat, 28 Nov 2015 15:00:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2lfX-00027O-Fc for emacs-devel@gnu.org; Sat, 28 Nov 2015 15:00:28 -0500 Original-Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:36675) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2lfV-000275-HH; Sat, 28 Nov 2015 15:00:25 -0500 Original-Received: by lfs39 with SMTP id 39so155743315lfs.3; Sat, 28 Nov 2015 12:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=GdrfoWSpIC4/W03J45NgOmuuHu7XBBKCIbPAqZKTUZw=; b=m//zYFP9jVffBIReX1tKsCUDAeqg3ZDP/bV7faYvggCZpvj6NX8RuTM+HL77+lQSDt C97XfuQLMgjYm1OZVGnzqVVRsHDhGu4MhPGQwUipkpnM7sUFLyXy/6TQ+sWI1URWsOZR +EuqfXCjVT7DR/rHh3C5SSWLXvBb86DUlvTPWF9a2znCWVoD5kxrc2/m4wCduAud8RnC bhw0PHScemLa37nCO9h5pWGAi3+KT3M6JbEq9R7PXPy0JeiJBdNcbD12EUPKimBzrVBI nrrBZL4qM/1mZ7ZWhnh5qXta0m4uhtKYQLhS5HJUJHjp891dJMMUKqoIU2Wh/eM+Aqpp EMOA== X-Received: by 10.25.20.217 with SMTP id 86mr21793619lfu.164.1448740824508; Sat, 28 Nov 2015 12:00:24 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Sat, 28 Nov 2015 12:00:24 -0800 (PST) In-Reply-To: <83610mosu2.fsf@gnu.org> X-Google-Sender-Auth: wcgvpziGWHgp5AI340mQoGt9CaU X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195478 Archived-At: Ok. I think that's still plausible for interactive uses. I'll add a comment to the docstring warning about the danger of long regexps, and I'll make sure isearch acts gracefully if such a situation is ever encountered. Still, this function can probably be optimized. I'll try to revisit it before release. 2015-11-28 18:57 GMT+00:00 Eli Zaretskii : >> Date: Sat, 28 Nov 2015 18:31:58 +0000 >> From: Artur Malabarba >> Cc: emacs-devel >> >> > Test character-fold--test-consistency condition: >> > (invalid-regexp "Regular expression too big") >> > FAILED 1/4 character-fold--test-consistency >> > passed 2/4 character-fold--test-fold-to-regexp >> > Test character-fold--test-lax-whitespace condition: >> > (invalid-regexp "Regular expression too big") >> > FAILED 3/4 character-fold--test-lax-whitespace >> > passed 4/4 character-fold--test-some-defaults >> > >> > Let me know if I can provide more information. >> >> Yes, I was getting this too. I reduced the length of the random strings in the >> test from 100 to 50 in order to stop getting this. But it looks like your >> system wants it to be even lower. >> >> Can you try reducing it a bit more? > > This works for me: > > diff --git a/test/automated/character-fold-tests.el b/test/automated/character-fold-tests.el > index 3a288b9..cf19584 100644 > --- a/test/automated/character-fold-tests.el > +++ b/test/automated/character-fold-tests.el > @@ -37,13 +37,13 @@ character-fold--test-search-with-contents > > > (ert-deftest character-fold--test-consistency () > - (dotimes (n 50) > + (dotimes (n 30) > (let ((w (character-fold--random-word n))) > ;; A folded string should always match the original string. > (character-fold--test-search-with-contents w w)))) > > (ert-deftest character-fold--test-lax-whitespace () > - (dotimes (n 50) > + (dotimes (n 40) > (let ((w1 (character-fold--random-word n)) > (w2 (character-fold--random-word n)) > (search-spaces-regexp "\\s-+"))