From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Questions about isearch
Date: Sat, 28 Nov 2015 20:00:24 +0000 [thread overview]
Message-ID: <CAAdUY-KH9JyM0Dn2J9NQ7VNUJY2ZjMeOz8xpgE0-wJ_QvKy91Q@mail.gmail.com> (raw)
In-Reply-To: <83610mosu2.fsf@gnu.org>
Ok. I think that's still plausible for interactive uses. I'll add a
comment to the docstring warning about the danger of long regexps, and
I'll make sure isearch acts gracefully if such a situation is ever
encountered.
Still, this function can probably be optimized. I'll try to revisit it
before release.
2015-11-28 18:57 GMT+00:00 Eli Zaretskii <eliz@gnu.org>:
>> Date: Sat, 28 Nov 2015 18:31:58 +0000
>> From: Artur Malabarba <bruce.connor.am@gmail.com>
>> Cc: emacs-devel <emacs-devel@gnu.org>
>>
>> > Test character-fold--test-consistency condition:
>> > (invalid-regexp "Regular expression too big")
>> > FAILED 1/4 character-fold--test-consistency
>> > passed 2/4 character-fold--test-fold-to-regexp
>> > Test character-fold--test-lax-whitespace condition:
>> > (invalid-regexp "Regular expression too big")
>> > FAILED 3/4 character-fold--test-lax-whitespace
>> > passed 4/4 character-fold--test-some-defaults
>> >
>> > Let me know if I can provide more information.
>>
>> Yes, I was getting this too. I reduced the length of the random strings in the
>> test from 100 to 50 in order to stop getting this. But it looks like your
>> system wants it to be even lower.
>>
>> Can you try reducing it a bit more?
>
> This works for me:
>
> diff --git a/test/automated/character-fold-tests.el b/test/automated/character-fold-tests.el
> index 3a288b9..cf19584 100644
> --- a/test/automated/character-fold-tests.el
> +++ b/test/automated/character-fold-tests.el
> @@ -37,13 +37,13 @@ character-fold--test-search-with-contents
>
>
> (ert-deftest character-fold--test-consistency ()
> - (dotimes (n 50)
> + (dotimes (n 30)
> (let ((w (character-fold--random-word n)))
> ;; A folded string should always match the original string.
> (character-fold--test-search-with-contents w w))))
>
> (ert-deftest character-fold--test-lax-whitespace ()
> - (dotimes (n 50)
> + (dotimes (n 40)
> (let ((w1 (character-fold--random-word n))
> (w2 (character-fold--random-word n))
> (search-spaces-regexp "\\s-+"))
next prev parent reply other threads:[~2015-11-28 20:00 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 18:41 Questions about isearch Eli Zaretskii
2015-11-25 19:20 ` Rasmus
2015-11-25 20:02 ` Steinar Bang
2015-11-26 14:46 ` Richard Stallman
2015-11-26 16:22 ` Eli Zaretskii
2015-11-26 20:46 ` Per Starbäck
2015-11-26 21:02 ` Eli Zaretskii
2015-11-26 21:35 ` Marcin Borkowski
2015-11-27 7:43 ` Eli Zaretskii
2015-11-27 6:38 ` Richard Stallman
2015-11-27 8:53 ` Eli Zaretskii
2015-11-27 16:21 ` raman
2015-11-26 23:18 ` Rasmus
2015-11-27 7:46 ` Eli Zaretskii
2015-11-27 6:37 ` Richard Stallman
2015-11-27 8:39 ` Eli Zaretskii
2015-11-25 20:10 ` Eli Zaretskii
2015-11-25 20:41 ` Mike Kupfer
2015-11-25 20:56 ` Eli Zaretskii
2015-11-25 20:14 ` Artur Malabarba
2015-11-25 20:30 ` Marcin Borkowski
2015-11-25 20:38 ` Eli Zaretskii
2015-11-25 21:58 ` Artur Malabarba
2015-11-25 23:04 ` Mike Kupfer
2015-11-26 3:40 ` Eli Zaretskii
2015-11-27 19:50 ` Mike Kupfer
2015-11-27 20:06 ` Eli Zaretskii
2015-11-27 23:57 ` Artur Malabarba
2015-11-28 1:36 ` Mike Kupfer
2015-11-28 9:28 ` Eli Zaretskii
2015-11-26 13:28 ` Steinar Bang
2015-11-25 20:36 ` Eli Zaretskii
2015-11-25 21:49 ` Artur Malabarba
2015-11-26 3:34 ` Eli Zaretskii
2015-11-27 12:03 ` Artur Malabarba
2015-11-27 14:36 ` Eli Zaretskii
2015-11-27 16:50 ` Per Starbäck
2015-11-27 18:10 ` Artur Malabarba
2015-11-27 18:42 ` Per Starbäck
2015-11-27 21:33 ` raman
2016-02-28 0:27 ` Mathias Dahl
2016-02-28 15:58 ` Eli Zaretskii
2016-02-28 17:52 ` Mathias Dahl
2016-02-28 18:02 ` Eli Zaretskii
2016-02-29 13:32 ` Richard Stallman
2016-02-29 16:04 ` Eli Zaretskii
2016-03-01 16:52 ` Richard Stallman
2015-11-27 16:55 ` Artur Malabarba
2015-11-27 17:52 ` Eli Zaretskii
2015-11-27 21:18 ` Stephen Berman
2015-11-28 0:04 ` Artur Malabarba
2015-11-28 7:49 ` Eli Zaretskii
2015-11-28 16:14 ` Stephen Berman
2015-11-28 5:36 ` Richard Stallman
2015-11-28 8:33 ` Eli Zaretskii
2015-11-28 8:40 ` Marcin Borkowski
2015-11-28 9:46 ` Eli Zaretskii
2015-11-28 10:23 ` Artur Malabarba
2015-11-28 11:14 ` Eli Zaretskii
2015-11-28 14:41 ` Eli Zaretskii
2015-11-28 15:41 ` Artur Malabarba
2015-11-28 16:29 ` Artur Malabarba
2015-11-28 17:27 ` Eli Zaretskii
2015-11-28 17:44 ` Eli Zaretskii
2015-11-28 18:31 ` Artur Malabarba
2015-11-28 18:57 ` Eli Zaretskii
2015-11-28 20:00 ` Artur Malabarba [this message]
2015-11-28 20:08 ` Artur Malabarba
2015-11-28 20:47 ` Eli Zaretskii
2015-11-28 16:48 ` character folding future [was: Questions about isearch] Drew Adams
2015-11-28 18:34 ` Artur Malabarba
2015-12-01 11:34 ` Artur Malabarba
2015-12-01 15:48 ` Drew Adams
2015-12-03 23:54 ` Artur Malabarba
2015-11-29 6:03 ` Questions about isearch Richard Stallman
2015-11-29 15:48 ` Eli Zaretskii
2015-11-29 9:39 ` Andreas Röhler
2015-11-29 15:52 ` Eli Zaretskii
2015-11-30 9:39 ` Andreas Röhler
2015-11-30 15:53 ` Eli Zaretskii
2015-11-30 16:05 ` Paul Eggert
2015-11-26 16:08 ` Rasmus
2015-11-25 23:15 ` Mike Kupfer
2015-11-26 14:45 ` Richard Stallman
2015-11-27 0:43 ` Juri Linkov
2015-11-27 8:07 ` Eli Zaretskii
2015-11-27 23:24 ` Juri Linkov
2015-11-28 8:09 ` Eli Zaretskii
2015-11-27 8:02 ` Andreas Röhler
2015-11-27 8:57 ` Eli Zaretskii
2015-11-27 10:03 ` Artur Malabarba
2015-11-27 10:29 ` Eli Zaretskii
2015-11-27 10:47 ` Artur Malabarba
2015-11-29 9:08 ` Andreas Röhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-KH9JyM0Dn2J9NQ7VNUJY2ZjMeOz8xpgE0-wJ_QvKy91Q@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.