Re: [Emacs-diffs] scratch/package.el-async-refresh bc0fc5e: Implement async refreshing in package-refresh-contents

Re: [Emacs-diffs] scratch/package.el-async-refresh bc0fc5e: Implement async refreshing in package-refresh-contents

[Stefan Monnier]

> +(defvar package--post-download-archives-hook nil
> +  "Hook run after the archive contents are downloaded.")
> +(put 'package--post-download-archives-hook 'risky-local-variable t)

> +(add-hook 'package--post-download-archives-hook #'package--notify-done)
> +(add-hook 'package--post-download-archives-hook #'package--build-compatibility-table)
> +(add-hook 'package--post-download-archives-hook #'package-read-all-archive-contents)

I think this is one of those places where the default value can directly
be placed in the defvar.  After all, this is an internal hook, so it
doesn't need to be easy to use.

I personally would only place a single function on it, tho (which then
calls the above 3 functions).  Or I would keep it nil by default, and
just put a call to that (new) function wherever you currently run
package--post-download-archives-hook.

> +  (add-hook 'package--post-download-archives-hook
> +            #'package-menu--populate-new-package-list 'append)
> +  (add-hook 'package--post-download-archives-hook
> +            #'package-menu--revert 'append)
> +  (add-hook 'package--post-download-archives-hook
> +            #'package-menu--find-and-notify-upgrades 'append)

Similarly, here I'd put a single function on the hook which then calls
those 3.


        Stefan

Re: [Emacs-diffs] scratch/package.el-async-refresh bc0fc5e: Implement async refreshing in package-refresh-contents

[Artur Malabarba]

> I personally would only place a single function on it, tho (which then
> calls the above 3 functions).  Or I would keep it nil by default, and
> just put a call to that (new) function wherever you currently run
> package--post-download-archives-hook.

Yes, I've changed it to this last one. Makes more sense here.

>
>> +  (add-hook 'package--post-download-archives-hook
>> +            #'package-menu--populate-new-package-list 'append)
>> +  (add-hook 'package--post-download-archives-hook
>> +            #'package-menu--revert 'append)
>> +  (add-hook 'package--post-download-archives-hook
>> +            #'package-menu--find-and-notify-upgrades 'append)
>
> Similarly, here I'd put a single function on the hook which then calls
> those 3.

Done.