all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: package.el dependencies
Date: Mon, 26 Jan 2015 10:46:02 -0200	[thread overview]
Message-ID: <CAAdUY-KCtwJJdf5vQBTGemO6z0C7-8p6UKmstT8u5ehXRjG5Zg@mail.gmail.com> (raw)
In-Reply-To: <87ppa1n9xr.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]

> > I think the orphan dependencies should be autoremoved immediately
> > after the package is deleted,
>
> No, not necessarily, it should not be an obligation, one can delete a
> package and make a cleanup later, it is what apt-get does.

Though, I'd prefer doing the cleanup immediately (it's what I've always
done with arch linux's pacman), this can be discussed some other time.
Getting this feature out is more important, so I'm ok with whatever you
chose here.

Still, that doesn't say why you'd need an `autoremove-list'. That's
something that's easy to calculate (I can write the implementation if you'd
like).


> > I agree. Why would we have kept it in this list? If a package is
> > deleted (without a newer version installed) it is removed from the
> > list.
>
> You assume the dependencies unneeded are removed straight after
> deleting, which is not the case.

Not really. The package-installed-explicitly is a list of installed
packages which the user manually requested, why would it ever contain
deleted packages?

We don't need this list to calculate unneeded dependencies. All we need is
the list of currently installed packages (package-alist) and the dependency
tree of currently installed packages (available inside the entries of
package-alist).


Maybe I just didn't quite understand what's the implementation you have in
mind, and maybe we're just talking different things. But, from what I
understand, we don't need to (and probably shouldn't) keep a list of
unneeded packages. Just calculating it with a function would be less code,
and would be safer (you never know what might have happened between an
Emacs restart).

Once your first patch is applied, I can provide an example implementation
for this if you'd like (just to show I'm trying to help, and not get in the
way :-)).

[-- Attachment #2: Type: text/html, Size: 2114 bytes --]

  reply	other threads:[~2015-01-26 12:46 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 13:37 package.el dependencies Thierry Volpiatto
2015-01-23 13:46 ` Dmitry Gutov
2015-01-23 14:12   ` Ivan Shmakov
2015-01-23 20:40 ` Stefan Monnier
2015-01-23 21:02   ` Thierry Volpiatto
2015-01-24  0:50     ` Artur Malabarba
2015-01-24  4:55       ` Stefan Monnier
2015-01-25  6:51         ` Thierry Volpiatto
2015-01-26  7:17         ` Thierry Volpiatto
2015-01-26  9:19           ` Artur Malabarba
2015-01-26  9:54             ` Thierry Volpiatto
2015-01-26 12:46               ` Artur Malabarba [this message]
2015-01-26 14:52           ` Stefan Monnier
2015-01-27  6:10             ` Thierry Volpiatto
2015-01-27 11:52               ` Artur Malabarba
2015-01-25  9:18   ` Thierry Volpiatto
2015-01-25 14:54     ` Stefan Monnier
2015-01-25 15:48       ` Thierry Volpiatto
2015-01-25 17:10         ` Dmitry Gutov
2015-01-25 18:32           ` Stephen Leake
2015-01-25 18:21         ` Artur Malabarba
2015-01-26  4:48           ` Thierry Volpiatto
2015-01-26 12:35             ` Artur Malabarba
2015-01-26 12:53         ` Artur Malabarba
2015-01-26 15:22   ` Thierry Volpiatto
2015-01-26 15:44     ` Stefan Monnier
2015-01-27  6:08       ` Thierry Volpiatto
2015-01-26 16:34     ` Artur Malabarba
2015-01-28  7:30   ` Thierry Volpiatto
2015-01-28  8:55     ` Thierry Volpiatto
2015-01-28 12:42       ` Thierry Volpiatto
2015-01-28 13:17         ` Artur Malabarba
2015-01-28 14:32           ` Thierry Volpiatto
2015-01-28 13:40         ` Dmitry Gutov
2015-01-28 10:47     ` Artur Malabarba
2015-01-28 11:58       ` Thierry Volpiatto
2015-01-28 19:33       ` Stefan Monnier
2015-01-28 19:50         ` Ivan Shmakov
2015-01-28 20:12           ` Artur Malabarba
2015-01-28 22:20           ` Stefan Monnier
2015-01-29  5:31         ` Thierry Volpiatto
2015-01-29  7:22           ` Thierry Volpiatto
2015-01-30  5:38   ` Thierry Volpiatto
2015-01-30 16:43     ` Artur Malabarba
2015-01-30 17:13       ` Thierry Volpiatto
2015-01-31  6:01       ` Thierry Volpiatto
2015-01-31 10:58         ` Artur Malabarba
2015-01-31 20:26         ` Stefan Monnier
     [not found]           ` <874mr67gjb.fsf@gmail.com>
     [not found]             ` <jwvvbjmnun4.fsf-monnier+emacs@gnu.org>
     [not found]               ` <87oapervqv.fsf@gmail.com>
     [not found]                 ` <jwvk302nnmd.fsf-monnier+emacs@gnu.org>
     [not found]                   ` <877fw2kp1y.fsf@gmail.com>
     [not found]                     ` <jwvioflbrlg.fsf-monnier+emacs@gnu.org>
     [not found]                       ` <87d25tps2q.fsf@gmail.com>
     [not found]                         ` <jwvy4oggva5.fsf-monnier+emacs@gnu.org>
2015-02-02 20:35                           ` Thierry Volpiatto
2015-02-02 21:37                             ` Artur Malabarba
2015-02-03  4:53                               ` Thierry Volpiatto
2015-02-03  5:13                                 ` Stefan Monnier
2015-02-03 10:04                                 ` Artur Malabarba
2015-02-03 14:06                                 ` Artur Malabarba
2015-02-03  5:45                               ` Thierry Volpiatto
2015-02-03 10:05                                 ` Artur Malabarba
2015-02-03 10:18                                   ` Thierry Volpiatto
2015-02-03 11:39                             ` Artur Malabarba
2015-02-02 21:19                           ` Thierry Volpiatto
2015-02-02 21:22                             ` Dmitry Gutov
2015-02-03 11:39                               ` Artur Malabarba
2015-02-03 11:44                                 ` Dmitry Gutov
2015-01-31  6:51       ` Thierry Volpiatto
2015-01-31 20:30         ` Stefan Monnier
2015-01-31 22:10           ` Thierry Volpiatto
2015-01-31 23:26           ` Artur Malabarba
2015-02-01  6:29             ` Thierry Volpiatto
2015-02-01  7:02             ` Thierry Volpiatto
2015-02-01 15:55             ` Thierry Volpiatto
2015-02-01 23:47               ` Artur Malabarba
2015-02-02 12:00           ` Artur Malabarba
2015-02-02 13:14             ` Thierry Volpiatto
2015-02-02 14:14               ` Thierry Volpiatto
2015-02-02 14:56                 ` Artur Malabarba
2015-02-02 15:19                   ` Thierry Volpiatto
2015-02-02 15:33                     ` Thierry Volpiatto
2015-02-02 15:50                       ` Artur Malabarba
2015-02-02 16:07                         ` Thierry Volpiatto
2015-02-02 21:23                         ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdUY-KCtwJJdf5vQBTGemO6z0C7-8p6UKmstT8u5ehXRjG5Zg@mail.gmail.com \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.