From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tassilo Horn <tsdh@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
21747@debbugs.gnu.org, Kim Storm <storm@cua.dk>
Subject: bug#21747: 25.0.50; while-no-input breaks kbd event handling when called from post-command-hook
Date: Sun, 25 Oct 2015 14:43:06 +0000 [thread overview]
Message-ID: <CAAdUY-KCPbF56OvM+0KTasgh+06WNmzNw=4Aooq34bLv=thiPA@mail.gmail.com> (raw)
In-Reply-To: <83vb9wwnc6.fsf@gnu.org>
2015-10-24 11:52 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
>> Date: Sat, 24 Oct 2015 11:30:42 +0100
>> From: Artur Malabarba <bruce.connor.am@gmail.com>
>> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, Kim Storm <storm@cua.dk>, 21747@debbugs.gnu.org,
>> Eli Zaretskii <eliz@gnu.org>
>>
>> So maybe the docstring for post-command-hook should point out this detail and
>> recommend that functions added to this hook call sit-for if they're going to do
>> potentially expensive processing.
>
> Just being potentially expensive is not enough to trigger the problem.
> You need to actually hog Emacs (or close to that) to prevent redisplay
> from eventually happening.
>
> I agree that expensive processing in post-command-hook is not a good
> idea (and said so several times in the past), but people are still
> doing that, so I guess just advertising the problem is not enough. (I
> don't object to adding this to documentation, of course.)
I've extended the docstring.
I used redisplay instead of (sit-for 0), because inside a call to
while-no-input it has the exact same effect and is more expressive.
Suggestions welcome.
-otherwise the error might happen repeatedly and make Emacs nonfunctional. */);
+otherwise the error might happen repeatedly and make Emacs nonfunctional.
+
+It is usually a bad idea to use this hook for expensive processing.
+If unavoidable, `while-no-input' can be used avoid making Emacs
+unresponsive while the user types. Furthermore, this hook is run
+before redisplay, so the effect of the executed command won't be
+displayed on the buffer until after the hook has finished (giving the
+impression that Emacs is hanging). You can call `redisplay' inside
+`while-no-input' to avoid this.
+
next prev parent reply other threads:[~2015-10-25 14:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 7:42 bug#21747: 25.0.50; while-no-input breaks kbd event handling when called from post-command-hook Tassilo Horn
2015-10-24 8:02 ` Eli Zaretskii
2015-10-24 8:53 ` Tassilo Horn
2015-10-24 9:14 ` Eli Zaretskii
2015-10-24 9:49 ` Tassilo Horn
2015-10-24 10:30 ` Artur Malabarba
2015-10-24 10:52 ` Eli Zaretskii
2015-10-24 12:13 ` Tassilo Horn
2015-10-24 12:45 ` Eli Zaretskii
2015-10-24 13:30 ` Tassilo Horn
2015-10-24 13:57 ` Artur Malabarba
2015-10-24 14:06 ` Eli Zaretskii
2015-10-24 14:05 ` Eli Zaretskii
2015-10-25 7:19 ` Tassilo Horn
2015-10-25 8:10 ` Tassilo Horn
2015-10-25 9:25 ` Tassilo Horn
2015-10-25 18:45 ` Eli Zaretskii
2015-10-25 18:49 ` Tassilo Horn
2015-10-25 20:10 ` Stefan Monnier
2015-10-26 6:57 ` Tassilo Horn
2015-10-25 18:43 ` Eli Zaretskii
2015-10-24 12:46 ` Tassilo Horn
2015-10-25 14:43 ` Artur Malabarba [this message]
2015-10-25 18:50 ` Eli Zaretskii
2015-10-26 0:27 ` Artur Malabarba
2015-10-26 3:32 ` Eli Zaretskii
2015-10-26 13:43 ` Tassilo Horn
2015-10-24 10:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdUY-KCPbF56OvM+0KTasgh+06WNmzNw=4Aooq34bLv=thiPA@mail.gmail.com' \
--to=bruce.connor.am@gmail.com \
--cc=21747@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=storm@cua.dk \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.